Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Insights warnings: tab stops and bounds fix. #1120

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

johnbeisner
Copy link

More Accessibility Insights fixes.

Reference: dotnet/core-setup#5549
Related: #1012

/cc @merriemcgaw @joeloff @dleeapho @dagood

@johnbeisner johnbeisner added the Area-Setup Acquisition and deployment team label Mar 25, 2019
@johnbeisner johnbeisner added this to the 3.0.1xx milestone Mar 25, 2019
@johnbeisner johnbeisner self-assigned this Mar 25, 2019
@johnbeisner johnbeisner requested review from nguerrera and a team March 25, 2019 19:28
@livarcocc
Copy link

@merriemcgaw gave me a list of other interesting scenarios to try. @johnbeisner could you try it out: Keyboard accessiblity (can you use the installer without a mouse) / High Contrast / Magnifier

@johnbeisner
Copy link
Author

johnbeisner commented Mar 25, 2019

Keyboard accessiblity - good experience
High Contrast # 1 - good experience
High Contrast # 2 - good experience
High Contrast Black - the hyperlinks are hard to read
High Contrast White - good experience
Magnifier - good experience

Untitled

@KathleenDollard
Copy link

Is this us or MSI?

@merriemcgaw
Copy link
Member

This is not a standard MSI window, we or WiX must be setting it.

@johnbeisner
Copy link
Author

The colors for the text, banner, background, et al are defined in the theme:
https://github.com/dotnet/core-sdk/blob/edadf5a7c504a551a0c2adee6df604e7263b303d/src/redist/targets/packaging/windows/clisdk/bundle.thm#L4-L9

The frame, buttons, links are defined by the 'High Contrast'

@johnbeisner
Copy link
Author

@merriemcgaw
Opened: #1130

@johnbeisner johnbeisner merged commit 91b94bc into dotnet:master Mar 26, 2019
@johnbeisner johnbeisner deleted the SDKBundleAccessibility branch April 23, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Setup Acquisition and deployment team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants