Create userlocal workload installation marker file for source build #12021
Conversation
dsplaisted
force-pushed
the
workload-userlocal-sourcebuild
branch
from
4a658bb to
a9e2a94
Compare
| @@ -466,6 +466,12 @@ | |||
| Overwrite="true" /> | |||
| </Target> | |||
|
|
|||
| <Target Name="LayoutWorkloadUserLocalMarker"> | |||
| <WriteLinesToFile File="$(RedistLayoutPath)metadata/workloads/userlocal" | |||
There was a problem hiding this comment.
In the issue, the version directory was lost when I copied over the information from the PR.
The path should include a version: /metadata/workloads/<sdkfeatureband>/userlocal.
The <sdkfeatureband> must not include the -suffix. So 6.0.100 (not 6.0.100-rc1).
| @@ -466,6 +466,12 @@ | |||
| Overwrite="true" /> | |||
| </Target> | |||
|
|
|||
| <Target Name="LayoutWorkloadUserLocalMarker"> | |||
There was a problem hiding this comment.
I think the file should only be written when building with source-build. i.e. Condition=" '$(DotNetBuildFromSource)' == 'true' "
You should be able to take the source tarball in the CI build artifacts (dotnet-sdk-source-6.0.100.tar.gz) and build it locally to test out the change. If you'd like me to help with that, let me know. |
| @@ -466,6 +466,13 @@ | |||
| Overwrite="true" /> | |||
| </Target> | |||
|
|
|||
| <Target Name="LayoutWorkloadUserLocalMarker" | |||
| Condition="'$(DotNetBuildFromSource)' == 'true'"> | |||
| <WriteLinesToFile File="$(RedistLayoutPath)metadata/workloads/$(CliProductBandVersion)00/userlocal" | |||
There was a problem hiding this comment.
This 00 looks like it may not be correct for patch releases?
There was a problem hiding this comment.
Yeah, that property is rather confusing.
|
@dsplaisted I downloaded and built the tarball from CI and it does create the file in the correct location and workloads were installed to my home directory. |
Fixes #12104