-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move core-sdk to arcade #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
port2arcade
branch
from
December 5, 2018 06:59
00f32c6
to
06ffd4a
Compare
dsplaisted
force-pushed
the
port2arcade
branch
from
December 5, 2018 07:37
06ffd4a
to
ec65352
Compare
… Windows) This means docker builds won't conflict with each other or with a non-docker build
That does look wrong to me. There's supposed to be one, but it is supposed to have only the sdk folder, and now it has everything. We're also missing VS.*.nupkg |
#198 would be blocked on having VS nupkgs produced. If we're dropping that in initial merge, can we do it soon after merge? |
dsplaisted
force-pushed
the
port2arcade
branch
from
December 11, 2018 22:43
2167a6a
to
0718b34
Compare
dsplaisted
force-pushed
the
port2arcade
branch
from
December 11, 2018 23:00
0718b34
to
d2a4791
Compare
…he build script on non-Windows
dsplaisted
force-pushed
the
port2arcade
branch
from
December 12, 2018 00:03
c079155
to
e5c8a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves core-sdk to the arcade infrastructure. Sending the PR now to test the CI changes.