Add current source-build prebuilts to support offline builds #14261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
force-pushed
the
sb-prebuilts
branch
2 times, most recently
from
85e817e to
259d712
Compare
MichaelSimons
force-pushed
the
sb-prebuilts
branch
from
259d712 to
72d92bd
Compare
|
Linking dotnet/source-build#2961 |
lbussell
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building offline surfaced two issues.
UpdateNuGetConfigPackageSourcesMappingstask didn't support offline correctly for two reasons. First, a clear element was getting added after each source-build packageSourceMapping if a clear didn't previously exist. Second, the source-build packageSourceMappings contained no packages in offline. This was caused by the use of LINQ and deferred evaluation. The online packageSourceMappings were removed prior to enumerating the LINQ statement.