Stop app host downloads for android #14266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maui apps by default have various android RIDs configured. In the RID graph, this ends up getting mapped onto linux and we end up searching for an apphost to download when building maui apps. However, these apps do not use apphosts so we should exclude android from the known app host lookup. We already exclude android elsewhere during the processing of known framework references and this is just extending that.
Customer Impact
Customers building Maui applications will download app hosts they don't need. This is particularly annoying for dogfooders when we are targeting prerelease servicing builds of the runtime as then they need an extra feed all for a set of packs they don't need.
Fix
Add ExcludedRuntimeIdentifiers="android" to the known app host reference in the generate bundled targets file.
Regression?
Risk
Verification