Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b0cd6df
Update dependencies from https://github.com/dotnet/sdk build 20190530.4
May 31, 2019
de22525
Run tests from dotnet/sdk
dsplaisted Apr 15, 2019
c534fca
Isolate SDK tests from repo Directory.Build files
dsplaisted Apr 15, 2019
cc94abf
Unset DOTNET environment variables for tests
dsplaisted Apr 15, 2019
380a828
Install previous runtimes for SDK tests
dsplaisted Apr 17, 2019
891a63e
Simplify global properties passed to run SDK tests
dsplaisted Apr 17, 2019
0f81d8a
Try UseCommandProcessor=false when calling dotnet-install script
dsplaisted Apr 18, 2019
a19b31a
Use bash to run dotnet-install.sh
dsplaisted Apr 18, 2019
c9655ad
Fix --install-dir parameter to dotnet-install.sh
dsplaisted Apr 18, 2019
bbd97e9
Unquote parameter
dsplaisted Apr 18, 2019
edbdcee
Use command processor
dsplaisted Apr 18, 2019
a494a1a
Don't parse dotnet-install output for errors
dsplaisted Apr 19, 2019
5d4d781
Unset environment variables for running SDK tests
dsplaisted Apr 23, 2019
22ad1f4
Continue build if there are test errors
dsplaisted Apr 23, 2019
e7c4d3e
Set test execution directory for SDK tests
dsplaisted Apr 23, 2019
7e7d65d
Support setting "partition" for arcade to avoid conflicts of .dotnet …
dsplaisted Apr 23, 2019
7490d12
Avoid trying to install 1.x runtimes when not supported
dsplaisted Apr 23, 2019
9e43e8a
Add TestConfig with SDK tests to skip, and other fixes for SDK tests
dsplaisted May 16, 2019
2eefd80
Add build environment script (with partition support)
dsplaisted May 16, 2019
78aab66
Install updated patch for sdk tests, skip additional test
dsplaisted May 17, 2019
66aaea7
Disable installing 1x runtimes on OS's where it's not available
dsplaisted May 17, 2019
db946eb
Skip additional SDK tests
dsplaisted May 17, 2019
6bbd497
Update dockerrun.ps1 to use ARCADE_PARTITION
dsplaisted May 17, 2019
2f4c5d1
Always gather logs
dsplaisted May 19, 2019
64ac44f
Capture STDERR in SDK test logs
dsplaisted May 20, 2019
733d569
Clean workspace
dsplaisted May 20, 2019
38c953c
Don't batch SDK test projects or continue on error
dsplaisted May 20, 2019
3e4671f
Install 1x runtimes on Windows
dsplaisted May 30, 2019
14ef1b6
Install runtime for SDK tests with correct architecture
dsplaisted May 30, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ dlldata.c

# Build artifacts
artifacts/
artifacts-*/
bin/
.dotnet/
.dotnet-*/

*_i.c
*_p.c
Expand Down
7 changes: 7 additions & 0 deletions Microsoft.DotNet.Cli.sln
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SdkResolver", "src\SdkResol
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Dotnet.Sdk.Internal", "src\Microsoft.Dotnet.Sdk.Internal\Microsoft.Dotnet.Sdk.Internal.csproj", "{73F07908-981B-41BB-B9BD-F3420274A6F7}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SdkTests", "test\SdkTests\SdkTests.csproj", "{CB1EE94E-CB83-4071-9DD0-9929AE2B7282}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -49,6 +51,10 @@ Global
{73F07908-981B-41BB-B9BD-F3420274A6F7}.Debug|Any CPU.Build.0 = Debug|Any CPU
{73F07908-981B-41BB-B9BD-F3420274A6F7}.Release|Any CPU.ActiveCfg = Release|Any CPU
{73F07908-981B-41BB-B9BD-F3420274A6F7}.Release|Any CPU.Build.0 = Release|Any CPU
{CB1EE94E-CB83-4071-9DD0-9929AE2B7282}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{CB1EE94E-CB83-4071-9DD0-9929AE2B7282}.Debug|Any CPU.Build.0 = Debug|Any CPU
{CB1EE94E-CB83-4071-9DD0-9929AE2B7282}.Release|Any CPU.ActiveCfg = Release|Any CPU
{CB1EE94E-CB83-4071-9DD0-9929AE2B7282}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand All @@ -59,6 +65,7 @@ Global
{53AF2D01-B69F-4CD0-86A7-8FD95967D23C} = {ED2FE3E2-F7E7-4389-8231-B65123F2076F}
{78E15EC1-7732-41E3-8591-934E9F583254} = {17735A9D-BFD9-4585-A7CB-3208CA6EA8A7}
{7EE15292-2CAD-44FA-8A1F-BAC4688A49E0} = {ED2FE3E2-F7E7-4389-8231-B65123F2076F}
{CB1EE94E-CB83-4071-9DD0-9929AE2B7282} = {17735A9D-BFD9-4585-A7CB-3208CA6EA8A7}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {B526D2CE-EE2D-4AD4-93EF-1867D90FF1F5}
Expand Down
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
<Uri>https://github.com/dotnet/standard</Uri>
<Sha>2c94a70248b2c4379ceffbade085f8d7eca4fee0</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Sdk" Version="3.0.100-preview6.19279.4">
<Dependency Name="Microsoft.NET.Sdk" Version="3.0.100-preview6.19280.4">
<Uri>https://github.com/dotnet/sdk</Uri>
<Sha>d6749cfae26412c188e26c247b15919afccef127</Sha>
<Sha>cda3914e2da64cf48029ac06dc043e039d1d1ee9</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.MSBuildSdkResolver" Version="3.0.100-preview6.19280.2">
<Uri>https://github.com/dotnet/cli</Uri>
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/dotnet/sdk (to run tests) -->
<MicrosoftNETSdkPackageVersion>3.0.100-preview6.19279.4</MicrosoftNETSdkPackageVersion>
<MicrosoftNETSdkPackageVersion>3.0.100-preview6.19280.4</MicrosoftNETSdkPackageVersion>
</PropertyGroup>
<PropertyGroup>
<MicrosoftNETCoreAppPackageVersion>3.0.0-preview6-27730-01</MicrosoftNETCoreAppPackageVersion>
Expand Down
6 changes: 4 additions & 2 deletions eng/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ phases:
pool: ${{ parameters.pool }}
${{ if ne(parameters.strategy, '') }}:
strategy: ${{ parameters.strategy }}
workspace:
clean: all

variables:
- _AgentOSName: ${{ parameters.agentOs }}
Expand Down Expand Up @@ -117,7 +119,7 @@ phases:
TestResults/$(_BuildConfig)/**/*
TargetFolder: '$(Build.ArtifactStagingDirectory)'
continueOnError: true
condition: not(succeeded())
condition: always()

- task: PublishBuildArtifacts@1
displayName: Publish Logs to VSTS
Expand All @@ -126,7 +128,7 @@ phases:
ArtifactName: '$(_AgentOSName)_$(Agent.JobName)_$(Build.BuildNumber)'
publishLocation: Container
continueOnError: true
condition: not(succeeded())
condition: always()

- ${{ if and(eq(parameters.enablePublishBuildAssets, true), eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- task: CopyFiles@2
Expand Down
9 changes: 9 additions & 0 deletions eng/common/tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,12 @@ function InitializeDotNetCli([bool]$install) {
if ((-not $globalJsonHasRuntimes) -and ($env:DOTNET_INSTALL_DIR -ne $null) -and (Test-Path(Join-Path $env:DOTNET_INSTALL_DIR "sdk\$dotnetSdkVersion"))) {
$dotnetRoot = $env:DOTNET_INSTALL_DIR
} else {

$dotnetRoot = Join-Path $RepoRoot ".dotnet"
if ($env:ARCADE_PARTITION -ne $null)
{
$dotnetRoot = Join-Path $RepoRoot ".dotnet-$env:ARCADE_PARTITION"
}

if (-not (Test-Path(Join-Path $dotnetRoot "sdk\$dotnetSdkVersion"))) {
if ($install) {
Expand Down Expand Up @@ -553,6 +558,10 @@ function GetMSBuildBinaryLogCommandLineArgument($arguments) {
$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot "..\..")
$EngRoot = Resolve-Path (Join-Path $PSScriptRoot "..")
$ArtifactsDir = Join-Path $RepoRoot "artifacts"
if ($env:ARCADE_PARTITION -ne $null)
{
$ArtifactsDir = Join-Path $RepoRoot "artifacts-$env:ARCADE_PARTITION"
}
$ToolsetDir = Join-Path $ArtifactsDir "toolset"
$ToolsDir = Join-Path $RepoRoot ".tools"
$LogDir = Join-Path (Join-Path $ArtifactsDir "log") $configuration
Expand Down
9 changes: 8 additions & 1 deletion eng/common/tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ function InitializeDotNetCli {
dotnet_root="$DOTNET_INSTALL_DIR"
else
dotnet_root="$repo_root/.dotnet"

if [[ -n "${ARCADE_PARTITION:-}" ]]; then
dotnet_root="$repo_root/.dotnet-$ARCADE_PARTITION"
fi
export DOTNET_INSTALL_DIR="$dotnet_root"

if [[ ! -d "$DOTNET_INSTALL_DIR/sdk/$dotnet_sdk_version" ]]; then
Expand Down Expand Up @@ -336,6 +338,11 @@ _script_dir=`dirname "$_ResolvePath"`
eng_root=`cd -P "$_script_dir/.." && pwd`
repo_root=`cd -P "$_script_dir/../.." && pwd`
artifacts_dir="$repo_root/artifacts"
if [[ -n "${ARCADE_PARTITION:-}" ]]; then
artifacts_dir="$repo_root/artifacts-$ARCADE_PARTITION"
export ArtifactsDir="$artifacts_dir/"
fi

toolset_dir="$artifacts_dir/toolset"
tools_dir="$repo_root/.tools"
log_dir="$artifacts_dir/log/$configuration"
Expand Down
41 changes: 41 additions & 0 deletions eng/core-sdk-build-env.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/usr/bin/env bash
#
# Copyright (c) .NET Foundation and contributors. All rights reserved.
# Licensed under the MIT license. See LICENSE file in the project root for full license information.
#

SOURCE="${BASH_SOURCE[0]}"
while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symlink
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$(readlink "$SOURCE")"
[[ "$SOURCE" != /* ]] && SOURCE="$DIR/$SOURCE" # if $SOURCE was a relative symlink, we need to resolve it relative to the path where the symlink file was located
done

REPO_ROOT="$( cd -P "$( dirname "$SOURCE" )/../" && pwd )"

arcade_partition=

while [[ $# > 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-partition)
arcade_partition=$2
shift
;;
esac

shift
done

export ARCADE_PARTITION=$arcade_partition

if [[ ! -z "$arcade_partition" ]]; then
arcade_partition_suffix="-$arcade_partition"
fi

export PATH=$REPO_ROOT/.dotnet$arcade_partition_suffix:$PATH
export DOTNET_INSTALL_DIR=$REPO_ROOT/.dotnet$arcade_partition_suffix
export ArtifactsDir=$REPO_ROOT/artifacts$arcade_partition_suffix/

export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export DOTNET_MULTILEVEL_LOOKUP=0
3 changes: 1 addition & 2 deletions eng/dockerrun.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ docker run $interactiveFlag -t --rm --sig-proxy=true `
-e PB_PACKAGEVERSIONPROPSURL `
-e PB_PUBLISHBLOBFEEDURL `
-e EXTERNALRESTORESOURCES `
-e ARCADE_DOTNET_DIR="/opt/code/artifacts/docker/${dockerImageName}/.dotnet" `
-e ARCADE_ARTIFACTS_DIR="/opt/code/artifacts/docker/${dockerImageName}/" `
-e ARCADE_PARTITION="${dockerImageName}" `
$dockerContainerTag `
/opt/code/run-build.sh @additionalArgs
Loading