Fix MS.Extensions versions in dotnet-format #14566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
force-pushed
the
fix-dotnet-format-versions
branch
from
9296b12 to
2904c60
Compare
MichaelSimons
approved these changes
Sep 21, 2022
mmitche
approved these changes
Sep 21, 2022
|
Pending this CI run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2000332&view=results (internal MS link) |
crummel
approved these changes
Sep 21, 2022
|
dotnet-watch test failure is dotnet/source-build#2961, it passed in both offline and bootstrap, so I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3032
Microsoft.Extensions.FileSystemGlobbing and Microsoft.Extensions.DependencyInjection could potentially be different versions, so they shouldn't use the same version number.