Patches to fix SB bootstrap flow #15532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Date: Tue, 14 Feb 2023 10:57:06 -0600 | ||
| Subject: [PATCH] Disable errors for FS1182 | ||
|
|
||
| --- |
There was a problem hiding this comment.
All patches should have a Backport: <Issue/PR reference> - e.g. https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/command-line-api/0001-Build-System.CommandLine.NamingConventionBinder-duri.patch#L7. This makes patch maintenance easier.
There was a problem hiding this comment.
The issue/pr when fixed should remove the need for the patch.
There was a problem hiding this comment.
I didn't do this for the roslyn patch because that's something to be addressed on the source-build side.
There was a problem hiding this comment.
We should still link the source-build issue(s) that will address the need for this patch.
This is replaced by the repo fix: dotnet/fsharp#14750
MichaelSimons
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsharp:
An analyzer warning, treated as an error, for FS1182 was causing a build failure due to an unused variable.
roslyn-analyzers:
An invalid cast exception was occurring when attempting to run a Roslyn analyzer during the sdk build. This is fixed by dotnet/roslyn-analyzers#6476 which I've applied the patch for here.
roslyn:
The IdeBenchmarks project was failing to build because it was attempting to load the Microsoft.NET.Sdk.WindowsDesktop.targets. It seemed that the
ToolsDirproperty wasn't flowing correctly which prevented the use of the EmptySdk for this scenario. However, the IdeBenchmarks project shouldn't be built at all. It's already configured to be excluded from source-build: https://github.com/dotnet/roslyn/blob/f3e29bfd6cfccdbd40bf28f295da11155a62f284/src/Tools/Directory.Build.props#L4. But there are existing issues with that flag: dotnet/source-build#1736, dotnet/source-build#1825.