Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source-build prebuilts and test baselines #15582

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

MichaelSimons
Copy link
Member

This should get a lot more of the internal CI legs to pass.

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Feb 17, 2023

@mthalman - this appears to be showing the same CI failure symptoms that #15495 addressed. Any ideas?

@NikolaMilosavljevic
Copy link
Member

@mthalman - this appears to be showing the same CI failure symptoms that #15495 addressed. Any ideas?

Could this be related to new flow from runtime that brought dependency on 4.6.0 Roslyn compiler? Due to repo re-ordering, we are now using Roslyn compiler that is in SDK:
https://github.com/dotnet/runtime/blob/a9dcf995cca0c5085c4e9bfacc43394d20569f68/eng/Versions.props#L27-L28

This creates the following warnings that later cause errors:

2023-02-17T16:32:45.4492089Z     CSC : warning CS8784: Generator 'JSExportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/AndroidAppBuilder/AndroidAppBuilder.csproj]

@MichaelSimons
Copy link
Member Author

Could this be related to new flow from runtime that brought dependency on 4.6.0 Roslyn compiler?

IDK - I am trying to update the SDK to align with the artifacts. It is definitely strange that this appears to have the same symptoms as we say with the issue that prompted #15495.

@MichaelSimons
Copy link
Member Author

It dawned on me that updating the SDK and artifacts now is not the correct action. This is going to happen as part of the preview 1 release. I reverted the changes. We will likely encounter the issue surfaced here later on.

@MichaelSimons MichaelSimons merged commit ce42123 into dotnet:main Feb 21, 2023
@MichaelSimons MichaelSimons deleted the sb-baselines branch February 21, 2023 17:10
@MichaelSimons MichaelSimons changed the title Update source-build artifacts, prebuilts and test baselines Update source-build prebuilts and test baselines Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants