Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/sdk #16391

Merged
merged 62 commits into from
May 19, 2023

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented May 12, 2023

Resolves #16410
This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 8.0.0-preview.5.23261.7 to 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0: from 8.0.0-preview.5.23261.7 to 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0: from 8.0.0-preview.5.23261.7 to 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • dotnet-user-jwts: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 8.0.0-preview.5.23262.1 to 8.0.0-preview.5.23268.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-preview.5.23261.7 to 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 8.0.0-preview.5.23260.4 to 8.0.0-preview.5.23267.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-preview.5.23261.7 to 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 8.0.0-preview.5.23261.1 to 8.0.0-preview.5.23267.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.FSharp.Compiler: from 12.7.0-beta.23260.3 to 12.7.0-beta.23267.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.fsharp: from 7.0.400-beta.23260.3 to 7.0.400-beta.23267.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Test.Sdk: from 17.7.0-preview.23261.1 to 17.7.0-preview.23267.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 4.7.0-2.23262.2 to 4.7.0-2.23268.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 17.7.0-preview-23260-01 to 17.7.0-preview-23267-02 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 6.7.0-preview.2.38 to 6.7.0-preview.2.44 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.5.23260.3 to 8.0.0-preview.5.23268.5 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: f8ee08b0-6c3d-485a-6895-08db0a1df366
  • Build: 20230518.34
  • Date Produced: May 19, 2023 12:43:19 AM UTC
  • Commit: 0d19178
  • Branch: refs/heads/main

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23262.4

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets
 From Version 8.0.0-preview.5.23262.1 -> To Version 8.0.0-preview.5.23262.5 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23262.6

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23260.3 -> To Version 8.0.0-preview.5.23262.9 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Copy link
Author

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23262.7

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23260.3 -> To Version 8.0.0-preview.5.23262.9 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23262.9

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23262.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23264.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23262.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23264.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23264.6

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@v-wuzhai
Copy link
Member

@dotnet/source-build-internal Could you take a look at the failures here?

dotnet-maestro bot and others added 2 commits May 15, 2023 10:51
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@MichaelSimons
Copy link
Member

@NikolaMilosavljevic - Could you help investigate the source-build failure here? Proactively pull in the repo owners as necessary. TIA.

lewing and others added 3 commits May 15, 2023 09:51
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.5

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.7

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic - Could you help investigate the source-build failure here? Proactively pull in the repo owners as necessary. TIA.

The errors are in msbuild repo. This repo is consuming just produced (in source-build) roslyn packages. Here's the link to log for previous source-build - new one has not started yet, but will likely fail with same issues:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=273593&view=logs&j=941f2e24-48a0-594a-6b1a-0e16aaeb8606

Example of errors:

2023-05-15T11:38:11.8526582Z /vmr/src/msbuild/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.7.0-2.23262.3/tasks/netcore/Microsoft.CSharp.Core.targets(80,5): error : Process terminated. System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'. [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0] 2023-05-15T11:38:11.8570897Z ##[error]/vmr/src/msbuild/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.7.0-2.23262.3/tasks/netcore/Microsoft.CSharp.Core.targets(80,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Process terminated. System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'.

System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'

@dotnet/roslyn-compiler - does this error look familiar?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.8

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic - Could you help investigate the source-build failure here? Proactively pull in the repo owners as necessary. TIA.

The errors are in msbuild repo. This repo is consuming just produced (in source-build) roslyn packages. Here's the link to log for previous source-build - new one has not started yet, but will likely fail with same issues: https://dev.azure.com/dnceng-public/public/_build/results?buildId=273593&view=logs&j=941f2e24-48a0-594a-6b1a-0e16aaeb8606

Example of errors:

2023-05-15T11:38:11.8526582Z /vmr/src/msbuild/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.7.0-2.23262.3/tasks/netcore/Microsoft.CSharp.Core.targets(80,5): error : Process terminated. System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'. [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0] 2023-05-15T11:38:11.8570897Z ##[error]/vmr/src/msbuild/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.7.0-2.23262.3/tasks/netcore/Microsoft.CSharp.Core.targets(80,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Process terminated. System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'.

System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'

@dotnet/roslyn-compiler - does this error look familiar?

The error points at System.Collections.Immutable and the new API that was added with dotnet/runtime#86210

cc @RaymondHuy

@RikkiGibson
Copy link

Full stack trace:

Process terminated. System.MissingMethodException: Method not found: 'Boolean System.Collections.Immutable.ImmutableArray`1.Contains(!0, System.Collections.Generic.IEqualityComparer`1<!0>)'. [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.ComputeInterfaceImplementations(BindingDiagnosticBag diagnostics, CancellationToken cancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.GetSynthesizedExplicitImplementations(CancellationToken cancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.ForceComplete(SourceLocation locationOpt, CancellationToken cancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbol.ForceCompleteMemberByLocation(SourceLocation locationOpt, Symbol member, CancellationToken cancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceNamespaceSymbol.<>c__DisplayClass66_1.<ForceComplete>b__0(Int32 i) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Roslyn.Utilities.UICultureUtilities.<>c__DisplayClass6_0`1.<WithCurrentUICulture>b__0(T param) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Roslyn.Utilities.RoslynParallel.<>c__DisplayClass1_0.<For>g__errorHandlingBody|0(Int32 i) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at System.Environment.FailFast(System.String, System.Exception) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.FailFast.OnFatalException(System.Exception) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.FailFast+<>c.<.cctor>b__5_0(System.Exception, Microsoft.CodeAnalysis.ErrorReporting.ErrorSeverity, Boolean) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception, Microsoft.CodeAnalysis.ErrorReporting.ErrorSeverity, Boolean) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.ErrorReporting.FatalError.ReportAndPropagate(System.Exception, Microsoft.CodeAnalysis.ErrorReporting.ErrorSeverity) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.ErrorReporting.FatalError.ReportAndPropagateUnlessCanceled(System.Exception, System.Threading.CancellationToken, Microsoft.CodeAnalysis.ErrorReporting.ErrorSeverity) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Roslyn.Utilities.RoslynParallel+<>c__DisplayClass1_0.<For>g__errorHandlingBody|0(Int32) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.ComputeInterfaceImplementations(Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, System.Threading.CancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.GetSynthesizedExplicitImplementations(System.Threading.CancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceMemberContainerTypeSymbol.ForceComplete(Microsoft.CodeAnalysis.SourceLocation, System.Threading.CancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbol.ForceCompleteMemberByLocation(Microsoft.CodeAnalysis.SourceLocation, Microsoft.CodeAnalysis.CSharp.Symbol, System.Threading.CancellationToken) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]
    at Microsoft.CodeAnalysis.CSharp.Symbols.SourceNamespaceSymbol+<>c__DisplayClass66_1.<ForceComplete>b__0(Int32) [/vmr/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=netstandard2.0]

Contains was called from SourceMemberContainerTypeSymbol.ComputeInterfaceImplementations.

When we click through the Contains calls on sourceroslyn, it points to an extension defined on IReadOnlyList. In the problematic build, I think we have a reference assembly which has this new Contains method on ImmutableArray, and we're picking it instead, even though it won't be available at runtime.

I tried to look for the binlog associated with this failed build, but I wasn't able to find it in the artifacts.

@NikolaMilosavljevic
Copy link
Member

Roslyn is packaging a reference assembly with Compilers toolset:
https://github.com/dotnet/roslyn/blob/ce19d97b15a1d0e26864d4ce60d190a3e9c6d37c/eng/Versions.props#L299
<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion>

Should this be updated during source-build via pvp flow? @MichaelSimons @mmitche

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.9

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@mmitche
Copy link
Member

mmitche commented May 15, 2023

Roslyn is packaging a reference assembly with Compilers toolset: https://github.com/dotnet/roslyn/blob/ce19d97b15a1d0e26864d4ce60d190a3e9c6d37c/eng/Versions.props#L299 <SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion>

Should this be updated during source-build via pvp flow? @MichaelSimons @mmitche

Yes. This should only be updated in source-build

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.10

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.11

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.13

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.15

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23265.16

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23264.1 (parent: Microsoft.NET.Sdk
@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented May 18, 2023

Source-build is failing because Microsoft.Net.Compilers.Toolset does not carry System.Collections.Immutable, and tries to load from toolset SDK, which is missing a new method.

Root cause is in ResolvePackageFileConflicts task (from Microsoft.NET.ConflictResolution.targets). Assembly reference was trimmed in favor of platform reference - here's the full message:

Encountered conflict between 'Platform:System.Collections.Immutable.dll' and 'CopyLocal:/vmr/src/roslyn/artifacts/source-build/self/package-cache/system.collections.immutable/8.0.0-preview.5.23267.8/lib/net8.0/System.Collections.Immutable.dll'. Choosing 'Platform:System.Collections.Immutable.dll' because it comes from a package that is preferred.

@mmitche @marcpopMSFT do you know why this would happen and who can help with this issue?

This is happening during build of csc.csproj.

Binlog: https://artprodcus3.artifacts.visualstudio.com/A6fcc92e5-73a7-4f88-8d13-d9045b45fb27/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2RuY2VuZy1wdWJsaWMvcHJvamVjdElkL2NiYjE4MjYxLWM0OGYtNGFiYi04NjUxLThjZGNiNTQ3NDY0OS9idWlsZElkLzI3Nzk0OC9hcnRpZmFjdE5hbWUvQ2VudE9TU3RyZWFtOF9PbmxpbmVfTXNmdFNka194NjRfQnVpbGRMb2dzX0F0dGVtcHQx0/content?format=file&subPath=%2Fsrc%2Froslyn%2Fartifacts%2FbuildLogs%2Fsource-build%2Fself%2Fsrc%2Fartifacts%2Fsourcebuild.binlog

dotnet-maestro bot and others added 7 commits May 18, 2023 17:51
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.14

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.16

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.18

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented May 18, 2023

@dotnet/domestic-cat you will need to review the win-arm changes

@ericstj
Copy link
Member

ericstj commented May 18, 2023

Source-build is failing because Microsoft.Net.Compilers.Toolset does not carry System.Collections.Immutable, and tries to load from toolset SDK, which is missing a new method.

Why are you running newly built code against the old (toolset) runtime? That seems to be the problem. SCI isn't included in the output because it's saying that the version referenced is <= the one in the (new) platform that you're targeting, but then you turn around and run it on an older platform.

Seems to me this build should either be using the toolset-ref-pack to build this thing that it wants to run on the toolset-runtime, or it can use the source-built-ref-pack to run on the source-built runtime. Don't mix and match, or the decisions made by the build could be wrong.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.21

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
@nagilson
Copy link
Member

@jkotas @lewing Thanks for going ahead and deleting the Win arm32 code. I'm not very knowledgeable about it, but the change lgtm. If we want another look from someone else lmk.

Regarding the issue above from @NikolaMilosavljevic

Source-build is failing because Microsoft.Net.Compilers.Toolset does not carry System.Collections.Immutable, and tries to load from toolset SDK, which is missing a new method.

The conflicting file appears to be coming from a copy managed by the VMR, @premun are you aware of anything that could've caused this?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.26

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented May 18, 2023

We're back down to the source-build failure wrt to System.Collections.Immutable

@NikolaMilosavljevic
Copy link
Member

We're back down to the source-build failure wrt to System.Collections.Immutable

Working on it - I've found the root cause: #16172 Looking into how to get roslyn to consume ref-pack from the SDK, instead of just-built one, in source-build. @mmitche any ideas?

dotnet-maestro bot and others added 3 commits May 18, 2023 23:31
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.32

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.33

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
@NikolaMilosavljevic
Copy link
Member

We're back down to the source-build failure wrt to System.Collections.Immutable

Working on it - I've found the root cause: #16172 Looking into how to get roslyn to consume ref-pack from the SDK, instead of just-built one, in source-build. @mmitche any ideas?

Pushed the fix - local build was successful.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-preview.5.23262.3 -> To Version 8.0.100-preview.5.23268.34

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-preview.5.23261.7 -> To Version 8.0.0-preview.5.23268.2 (parent: Microsoft.NET.Sdk
@lewing lewing enabled auto-merge May 19, 2023 02:12
@lewing lewing merged commit 63da970 into main May 19, 2023
@lewing lewing deleted the darc-main-b3493948-ba4e-418f-85b9-c4d9e5a8b57d branch May 19, 2023 03:18
@lewing
Copy link
Member

lewing commented May 19, 2023

automerge apparently merged inside the reset window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error downloading runtime