source-build: bundle runtime packs with the sdk.

[tmds]

Contributes to dotnet/source-build#1215.

@dsplaisted @MichaelSimons ptal.

cc @ashnaga @omajid @uweigand

[tmds]

Tested on my machine:

$ dotnet publish --sc -r fedora.37-x64
MSBuild version 17.7.0-preview-23272-02+d077d294f for .NET
  Determining projects to restore...
  Restored /tmp/web2/web2.csproj (in 98 ms).
/home/tmds/Downloads/extract2/with_aspnetcore/sdk/8.0.100-preview.5.23273.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/tmp/web2/web2.csproj]
  web2 -> /tmp/web2/bin/Release/net8.0/fedora.37-x64/web2.dll
  web2 -> /tmp/web2/bin/Release/net8.0/fedora.37-x64/publish/

🎉

It would be nice to have an argument - similar to --use-current-runtime - that means: the non-portable rid.

Alternatively, one can already add:

<RuntimeIdentifier>$(NETCoreSdkRuntimeIdentifier)</RuntimeIdentifier>

Using rdfind I created hard links between the packs and their corresponding shared folder (assuming these would be distributed in the same repository package).

That leaves these two unique files in the .NET Core runtime pack:

-rwxr--r--. 1 tmds tmds  39K May 25 09:19 ./8.0.0-preview.5.23272.4/data/RuntimeList.xml
-rwxr--r--. 1 tmds tmds 4.1M May 25 09:19 ./8.0.0-preview.5.23272.4/runtimes/fedora.37-x64/native/libhostfxr.so

And these two unique files in the ASP.NET Core runtime pack:

-rwxr--r--. 1 tmds tmds  13K May 25 09:19 ./8.0.0-preview.5.23272.6/data/PlatformManifest.txt
-rwxr--r--. 1 tmds tmds  34K May 25 09:19 ./8.0.0-preview.5.23272.6/data/RuntimeList.xml

So we get source-build self-contained at the small cost of 4.2MB in size (provided the repo packages support hard links).

[tmds]

I've added a property (BundleRuntimePacks) that allows to toggle the feature on and off.

When turned on, we'll try to call rdfind to remove duplicates.
If the tool isn't available, a message is printed.

Because the tool may not be available on every distro, I'll look into replacing the rdfind invocation with a custom Task in another PR.

[tmds]

@ashnaga @MichaelSimons can this still be part or preview5?

[dsplaisted]

Awesome!

[dsplaisted]

Is SharedFrameworkRid the same as ProductMonikerRid? ProductMonikerRid is used earlier for the known framework reference RIDs.

[tmds]

I'm using the same parameters as we were are already using for the app host, and they are both equal to the non-portable rid.

[MichaelSimons]

@tmds - Can you log a follow-up test to ensure we adjust the source-build tests run a self-contained scenario and verify the runtime pack doesn't get pulled from NuGet? The change @mthalman is making in #16359 should make this a lot easier.

@ashnaga @MichaelSimons can this still be part or preview5?

I am going to defer this to @marcpopMSFT and @dsplaisted since this is an installer product change.

[tmds]

Can you log a follow-up test to ensure we adjust the source-build tests run a self-contained scenario and verify the runtime pack doesn't get pulled from NuGet?

Created dotnet/source-build#3485.

[tmds]

Because the tool may not be available on every distro, I'll look into replacing the rdfind invocation with a custom Task in another PR.

@MichaelSimons what is the best place to put this Task? Is it https://github.com/dotnet/installer/tree/main/src/core-sdk-tasks? Or does it belong somewhere else?

[MichaelSimons]

@MichaelSimons what is the best place to put this Task? Is it https://github.com/dotnet/installer/tree/main/src/core-sdk-tasks? Or does it belong somewhere else?

I will defer to @dsplaisted.

[MichaelSimons]

Per today's tactics meeting, we are at the point in the release cycle that only critical fixes are being accepted for preview 5. It sounds like this will have to be deferred to preview 6.

cc @mmitche for visibility.