Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source-build pvp flow for installer #16550

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

MichaelSimons
Copy link
Member

Related to dotnet/source-build#3043

This PR contains a number of related changes:

  1. Enabled the source-build per repo pvp flow for the installer repo.
  2. With the per repo pvp flow enabled it surfaced the nuget prebuilts already included in the prebuilt baseline. To fix this, I modified the nuget dependency to be a live/latest dependency.
  3. Refactored the source-build baseline because of the nuget dependency update.
  4. Since I was touching the source-build prebuilt baseline, I updated a few source-build files to help ensure source-build-internal is included in reviewing changes.

If you feel I have overloaded this PR please let me know and I will break it apart.

@MichaelSimons MichaelSimons requested a review from a team as a code owner May 31, 2023 22:37
@@ -1,23 +1,15 @@
<!-- Whenever altering this or other Source Build files, please include @dotnet/source-build-internal as a reviewer. -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksandr-didyk - I am proposing a slight wording change to reduce the length of the message. I also introduced a blank link before the first element.

eng/Versions.props Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@MichaelSimons MichaelSimons requested a review from mthalman June 1, 2023 15:38
@MichaelSimons MichaelSimons enabled auto-merge (squash) June 1, 2023 17:12
@MichaelSimons MichaelSimons merged commit 8f01b7d into dotnet:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants