SDK diff - fix for vstest and fsharp #16751
Conversation
| ./sdk/x.y.z/cs/Microsoft.TemplateEngine.Orchestrator.RunnableProjects.resources.dll | ||
| ./sdk/x.y.z/cs/Microsoft.TemplateEngine.Utils.resources.dll | ||
| ./sdk/x.y.z/cs/Microsoft.TemplateSearch.Common.resources.dll | ||
| +./sdk/x.y.z/cs/Microsoft.TestPlatform.Build.resources.dll |
There was a problem hiding this comment.
So what's the story for this file? This doesn't seem addressed by the patch.
There was a problem hiding this comment.
Good catch - this is in a separate nupkg: Microsoft.TestPlatform.Build
Working on a fix.
There was a problem hiding this comment.
Something with SDK composition is incorrect - this localized binary was already included in the relevant nupkg.
There was a problem hiding this comment.
Argh - this is funny - this is just a diff showing what's not in baseline anymore. No issue here.
|
|
||
| # nuget localization is not available for Linux builds - https://github.com/NuGet/Home/issues/12440 | ||
| msft,./sdk/x.y.z/*?/NuGet.*?.resources.dll | ||
| msft,./sdk/x.y.z/*?/Microsoft.Build.NuGetSdkResolver.resources.dll | ||
| msft,./sdk/x.y.z/*?/Test.Utility.resources.dll |
There was a problem hiding this comment.
I didn't realize this was a NuGet assembly. The name is something I would not expect from them.
There was a problem hiding this comment.
I'm not 100% sure how or why it's included in Microsoft-built SDK. However, the binary is versioned as all other nuget.client binaries, and the IL contains resources consumed by this nuget.client project: https://github.com/NuGet/NuGet.Client/tree/dev/test/TestUtilities/Test.Utility
Fixes: dotnet/source-build#3290, dotnet/source-build#3517
VSTest localization was enabled on Linux recently - this PR includes a patch for inclusion of localized resources in the CLI package: microsoft/vstest#4564
FSharp binaries are all Windows components or transitive dependencies of those components - adding to the exclusion list, as this difference is now understood.
Also moving the following exclusion entry to the correct section (NuGet):