Ignore IDE0044 for vstest #18100
Merged
Ignore IDE0044 for vstest #18100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
approved these changes
Jan 4, 2024
sharwell
reviewed
Jan 4, 2024
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
ViktorHofer
reviewed
Jan 5, 2024
| @@ -6,6 +6,9 @@ | |||
| <BuildCommandArgs>$(BuildCommandArgs) /p:SemanticVersioningV1=true</BuildCommandArgs> | |||
| <BuildCommand>$(ProjectDirectory)\eng\common\build$(ShellExtension) $(BuildCommandArgs)</BuildCommand> | |||
| <DeterministicBuildOptOut>true</DeterministicBuildOptOut> | |||
|
|
|||
| <!-- https://github.com/dotnet/source-build/issues/3814 --> | |||
| <NoWarn>$(NoWarn),IDE0044</NoWarn> | |||
There was a problem hiding this comment.
Curious, where is that NoWarn setting respected when building the repo?
There was a problem hiding this comment.
Viktor brings up a good point that I overlooked. The NoWarn infra was removed with #17712.
There was a problem hiding this comment.
Yep, I just saw that myself. Confirmed that the build is not fixed by this. My bad. I will create a patch to address the code fixes. They are pretty simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3814