Follow-up on enabling Windows VMR build #18239
Conversation
- Collapsed(Intermediate)OutputPath -> Shared(Intermediate)OutputPath - Move Artifacts property next to others - Add comment to build.sh to enable building without building from source on Unix
| @@ -124,14 +124,13 @@ | |||
|
|
|||
| <!-- TODO: Remove when all repos use a consistent set of eng/common files: https://github.com/dotnet/source-build/issues/3710. --> | |||
| <Target Name="UpdateEngCommonFiles" | |||
| Condition="'$(RepositoryName)' != 'arcade' and ('$(UpdateEngCommonFiles)' == 'true' or '$(DotNetBuildVertical)' == 'true')" | |||
| Condition="'$(UpdateEngCommonFiles)' == 'true' or '$(DotNetBuildVertical)' == 'true'" | |||
There was a problem hiding this comment.
I thought this was going to be updated to use UseBootstrapArcade instead?
There was a problem hiding this comment.
@mmitche and I chatted offline and we realized that the VMR root's eng/common folder is identical with the one under src/arcade and src/installer. It's also the most up-to-date one which makes it the preferred origin for use in the vertical builds, until we come up with a better design (tracked via dotnet/source-build#3710).
The Copy task skips any files that are identical so this is a no-op for Arcade and Installer.
There was a problem hiding this comment.
It's also the most up-to-date one which makes it the preferred origin for use in the vertical builds
You really can't say that for the bootstrap repos given they use the n-1 arcade. I agree though that the contents will be identical therefore either implementation doesn't change the behavior. As you said, this will need dotnet/source-build#3710 to solve.
Follow-up on #18214