Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebootstrap with latest changes #19555

Closed
wants to merge 3 commits into from
Closed

Rebootstrap with latest changes #19555

wants to merge 3 commits into from

Conversation

ellahathaway
Copy link
Member

Closes dotnet/source-build#4348

Rebootstraps the VMR with artifacts from https://dev.azure.com/dnceng/internal/_build/results?buildId=2433339&view=results (internal Microsoft link)

@ellahathaway ellahathaway requested review from a team as code owners April 22, 2024 18:01
ViktorHofer
ViktorHofer requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Version.Details.xml in the VMR as well

@ellahathaway ellahathaway mentioned this pull request Apr 22, 2024
Closed
@ellahathaway
Copy link
Member Author

Will need to add a runtime patch for https://github.com/dotnet/runtime/pull/101302/files and wait for a new build. Then I will update this PR with a new rebootstrap.

@ellahathaway ellahathaway mentioned this pull request Apr 22, 2024
Merged
@ViktorHofer
Copy link
Member

@andriipatsula looks like the failures are related to your ManifestRepoOrigin work.

@ViktorHofer
Copy link
Member

Looks like we need another re-bootstrap after dotnet/arcade#14723 is merged and has flowed into installer.

@andriipatsula
Copy link
Member

@andriipatsula looks like the failures are related to your ManifestRepoOrigin work.

The "ManifestRepoOrigin" parameter is not supported by the "PushToBuildStorage" task loaded from assembly: Microsoft.DotNet.Build.Tasks.Feed, Version=9.0.10.21701

Looks like we need another re-bootstrap after dotnet/arcade#14723 is merged and has flowed into installer.

I think you are right here. the version that includes my changes into the PushToBuildStorage MSBuild task.

@ViktorHofer ViktorHofer mentioned this pull request Apr 23, 2024
Merged
@ellahathaway
Copy link
Member Author

Closing per #19562 (comment).

@ellahathaway ellahathaway deleted the rebootstrap branch June 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@MichaelSimons MichaelSimons Awaiting requested review from MichaelSimons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-bootstrap tooling/artifacts in main to latest
5 participants
@ellahathaway @ViktorHofer @andriipatsula @akoeplinger @MichaelSimons