Remove unused files #19707
Merged
Remove unused files #19707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Remove snaps as they are now owned by Canonical via dotnet/announcements#304.
nagilson
approved these changes
May 7, 2024
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
LGTM, but it'd be good to get a review from another person.
ViktorHofer
approved these changes
May 8, 2024
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
May 15, 2024
…4262.2 Context: dotnet/installer#19707 Changes: dotnet/installer@fa261b9...1741345 Changes: dotnet/runtime@4326eb7...84b3339 Changes: dotnet/cecil@4abe3e6...7a4a59f dotnet/installer is no longer producing a `Microsoft.Dotnet.Sdk.Internal` "package" for the SDK. This is causing the maestro code-flow to fail, such as: > darc update-dependencies --id 225276 Looking up build with BAR id 225276 Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Found no dependencies to update. We use `Microsoft.Dotnet.Sdk.Internal` to provision the .NET SDK, similar to: ./dotnet-install.sh --version $(MicrosoftDotnetSdkInternalPackageVersion) Where `eng/Versions.props` is updated by the Maestro bot for the version number. Looking for the `Microsoft.Dotnet.Sdk.Internal` dependency, such as: > darc gather-drop --id 225276 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240512.2 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ 1741345c6399ae203d8f259fb12fb873dac5129d But we can find the package for .NET 9 Preview 4: > darc gather-drop --id 225611 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240515.4 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ df80b5eb607242b1d8ded158ec97a25e5d5e5e05 Skipping non-shipping asset Microsoft.Dotnet.Sdk.Internal@9.0.100-preview.4.24265.4 For now, we can use `VS.Tools.Net.Core.SDK.Resolver` instead, as this is a component inserted into Visual Studio that contains the same version number. We may have to change this again in the future, as dotnet/installer is in the process of merging and/or moving to dotnet/sdk. MS employees can see more details in the [MS Teams thread][0]. [0]: https://teams.microsoft.com/l/message/19:afba3d1545dd45d7b79f34c1821f6055@thread.skype/1715789991637?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1715789991637&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1715789991637
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
May 16, 2024
…4262.2 (#8949) Context: dotnet/installer#19707 Changes: dotnet/installer@fa261b9...1741345 Changes: dotnet/runtime@4326eb7...84b3339 Changes: dotnet/cecil@4abe3e6...7a4a59f dotnet/installer is no longer producing a `Microsoft.Dotnet.Sdk.Internal` "package" for the SDK. This is causing the maestro code-flow to fail, such as: > darc update-dependencies --id 225276 Looking up build with BAR id 225276 Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Found no dependencies to update. We use `Microsoft.Dotnet.Sdk.Internal` to provision the .NET SDK, similar to: ./dotnet-install.sh --version $(MicrosoftDotnetSdkInternalPackageVersion) Where `eng/Versions.props` is updated by the Maestro bot for the version number. There is no `Microsoft.Dotnet.Sdk.Internal` package from the build, such as: > darc gather-drop --id 225276 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240512.2 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ 1741345c6399ae203d8f259fb12fb873dac5129d But we can find the package for .NET 9 Preview 4: > darc gather-drop --id 225611 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240515.4 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ df80b5eb607242b1d8ded158ec97a25e5d5e5e05 Skipping non-shipping asset Microsoft.Dotnet.Sdk.Internal@9.0.100-preview.4.24265.4 For now, we can use `VS.Tools.Net.Core.SDK.Resolver` instead, as this is a component inserted into Visual Studio that contains the same version number. We may have to change this again in the future, as dotnet/installer is in the process of merging and/or moving to dotnet/sdk. MS employees can see more details in the [MS Teams thread][0]. [0]: https://teams.microsoft.com/l/message/19:afba3d1545dd45d7b79f34c1821f6055@thread.skype/1715789991637?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1715789991637&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1715789991637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CC @rbhanda @leecow