[release/5.0.1xx-preview1] Update dependencies from dotnet/windowsdesktop #6473

dotnet-maestro · 2020-02-19T23:41:34Z

This pull request updates the following dependencies

From https://github.com/dotnet/windowsdesktop

Subscription: fd716221-3efd-4629-c9a9-08d7b0e007f5
Build: 20200220.3
Date Produced: 2/20/2020 11:39 PM
Commit: a7557e0b28db9bcb1d024cd6a9742f3773c145b2
Branch: refs/heads/release/5.0-preview1
Updates:
- Microsoft.WindowsDesktop.App -> 5.0.0-preview.1.20120.3
- Microsoft.WindowsDesktop.App.Ref -> 5.0.0-preview.1.20120.3
- Microsoft.WindowsDesktop.App.Runtime.win-x64 -> 5.0.0-preview.1.20120.3

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Microsoft.Dotnet.WinForms.ProjectTemplates -> 5.0.0-preview.1.20118.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
Microsoft.DotNet.Wpf.ProjectTemplates -> 5.0.0-preview.1.20119.9 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

…ld 20200219.4 - Microsoft.WindowsDesktop.App - 5.0.0-preview.1.20119.4 - Microsoft.WindowsDesktop.App.Ref - 5.0.0-preview.1.20119.4 - Microsoft.WindowsDesktop.App.Runtime.win-x64 - 5.0.0-preview.1.20119.4 Dependency coherency updates - Microsoft.Dotnet.WinForms.ProjectTemplates - 5.0.0-preview.1.20118.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64) - Microsoft.DotNet.Wpf.ProjectTemplates - 5.0.0-preview.1.20119.9 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

wtgodbe · 2020-02-20T17:06:24Z

D:\a\1\s\src\redist\targets\GenerateLayout.targets(332,5): error : Problems downloading file from 'https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/5.0.0-preview.1.20119.4/windowsdesktop-runtime-5.0.0-preview.1.20119.4-win-x86.zip'. Does the resource exist on the storage? NotFound : The specified blob does not exist. [D:\a\1\s\src\redist\redist.csproj]

Indeed, the blob doesn't exist - there is no 5.0.0-preview.1.20119.4 folder under WindowsDesktop in dotnetcli. The latest is 5.0.0-preview.1.20118.4. @vatsan-madhavan who can help investigate this?

vatsan-madhavan · 2020-02-20T21:53:23Z

@MattGal another infra problem ?

nguerrera · 2020-02-20T22:09:30Z

Retrying

nguerrera · 2020-02-20T22:13:42Z

No dice

Problems downloading file from 'https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/5.0.0-preview.1.20119.4/windowsdesktop-runtime-5.0.0-preview.1.20119.4-win-x86.zip'

cc @dagood @vatsan-madhavan

EDIT: Sorry for the duplicate information to above

MattGal · 2020-02-20T22:27:42Z

@MattGal another infra problem ?

sounds like an azure storage issue but I'm taking a look to be sure.

MattGal · 2020-02-20T22:32:24Z

I verified the latest up there is https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/5.0.0-preview.1.20118.4/windowsdesktop-runtime-5.0.0-preview.1.20118.4-win-x86.zip . Where is this supposed to be getting published? perhaps that was done incompletely.

nguerrera · 2020-02-20T22:33:47Z

I believe from dotnet/windowsdesktop repo

MattGal · 2020-02-20T22:40:49Z

I believe from dotnet/windowsdesktop repo

OK... not super familiar with them but I'll go see if I can hunt down a publish failure in their builds.

dagood · 2020-02-20T22:41:28Z

Should be from https://dev.azure.com/dnceng/internal/_build/results?buildId=528751&view=results. Maybe the channel isn't configured right to publish to dotnetcli blob storage?

dagood · 2020-02-20T22:44:31Z

Ah yep, no 5p1 channel configuration in https://github.com/dotnet/windowsdesktop/blob/2bfe43eb8e4fc90388a150634dab891b2aa15ef4/azure-pipelines.yml#L87-L101. Should consider porting dotnet/core-setup#8426 to that repo so channel additions aren't necessarily breaking changes.

nguerrera · 2020-02-20T22:47:27Z

Who's on point to fix this?

nguerrera · 2020-02-20T22:47:51Z

Thanks for tracking that down!

dagood · 2020-02-20T22:51:03Z

@NikolaMilosavljevic is probably the right person to take point on this since it's an issue in windowsdesktop infra inherited from core-setup. I'll work with him to get this addressed quickly.

vatsan-madhavan · 2020-02-20T23:02:21Z

I'll work with him to get this addressed quickly.

👍 Should this be fixed in master as well?

/cc @dotnet/wpf-developers , @RussKie, @AdamYoblick

dagood · 2020-02-20T23:05:44Z

I have dotnet/windowsdesktop#531 and dotnet/windowsdesktop#532 submitted to absorb the channel addition break. Porting the PR I mentioned above (and any other involved changes) can be tracked separately to avoid this being a break in the future, I'll file an issue.

dagood · 2020-02-20T23:08:57Z

Filed dotnet/windowsdesktop#533 to track the long term fix.

dagood · 2020-02-20T23:21:50Z

This windowsdesktop build is now running with the fix: https://dev.azure.com/dnceng/internal/_build/results?buildId=530513&view=results

…ld 20200220.3 - Microsoft.WindowsDesktop.App - 5.0.0-preview.1.20120.3 - Microsoft.WindowsDesktop.App.Ref - 5.0.0-preview.1.20120.3 - Microsoft.WindowsDesktop.App.Runtime.win-x64 - 5.0.0-preview.1.20120.3 Dependency coherency updates - Microsoft.Dotnet.WinForms.ProjectTemplates - 5.0.0-preview.1.20118.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64) - Microsoft.DotNet.Wpf.ProjectTemplates - 5.0.0-preview.1.20119.9 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

dagood · 2020-02-21T00:04:14Z

Looks like the build got added to the channel before publishing completed. 🤦‍♂

The NuGet Validate stage failed with a funky AzDO error, I posted in the First Responder Teams about it and hit retry because it looks like it could be network flakiness. Keep an eye on https://dev.azure.com/dnceng/internal/_build/results?buildId=530513&view=results to see when to retry this PR.

dotnet-maestro · 2020-02-21T00:07:30Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

wtgodbe · 2020-02-21T00:37:34Z

@dagood the PR is green, are we good to go?

dotnet-maestro · 2020-02-21T00:37:49Z

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

✔️ Standard Merge Policies Succeeded - Successful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Arm64_Debug), .NET Core core-sdk CI (build Linux Build_Arm_Debug), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_arm), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

wtgodbe · 2020-02-21T00:38:48Z

Never mind, the bot did it for us 😆

nguerrera · 2020-02-21T00:40:08Z

Thanks, all!

This comment has been minimized.

Sign in to view

dagood mentioned this pull request Feb 20, 2020

Port change from Core-Setup to rely on Arcade for dotnetcli blob storage publishing dotnet/windowsdesktop#533

Closed

dagood mentioned this pull request Feb 20, 2020

[release/5.0-preview1] Add channel for '.NET 5 Preview 1' dotnet/windowsdesktop#532

Merged

This comment has been minimized.

Sign in to view

dotnet-maestro bot merged commit c59ea73 into release/5.0.1xx-preview1 Feb 21, 2020

dotnet-maestro bot deleted the darc-release/5.0.1xx-preview1-bae9476b-13df-4b81-9888-1108c5731696 branch February 21, 2020 00:37

dagood mentioned this pull request Feb 21, 2020

[release/5.0.1xx-preview1] Update dependencies from dotnet/windowsdesktop #6502

Merged

[release/5.0.1xx-preview1] Update dependencies from dotnet/windowsdesktop #6473

[release/5.0.1xx-preview1] Update dependencies from dotnet/windowsdesktop #6473

Conversation

dotnet-maestro bot commented Feb 19, 2020 • edited Loading

From https://github.com/dotnet/windowsdesktop

Coherency Updates

This comment has been minimized.

wtgodbe commented Feb 20, 2020

This comment has been minimized.

vatsan-madhavan commented Feb 20, 2020

This comment has been minimized.

nguerrera commented Feb 20, 2020

This comment has been minimized.

nguerrera commented Feb 20, 2020 • edited Loading

This comment has been minimized.

MattGal commented Feb 20, 2020

This comment has been minimized.

MattGal commented Feb 20, 2020

nguerrera commented Feb 20, 2020

This comment has been minimized.

MattGal commented Feb 20, 2020

dagood commented Feb 20, 2020

This comment has been minimized.

dagood commented Feb 20, 2020

This comment has been minimized.

nguerrera commented Feb 20, 2020

nguerrera commented Feb 20, 2020

dagood commented Feb 20, 2020

This comment has been minimized.

vatsan-madhavan commented Feb 20, 2020

dagood commented Feb 20, 2020 • edited Loading

This comment has been minimized.

dagood commented Feb 20, 2020

This comment has been minimized.

dagood commented Feb 20, 2020

This comment has been minimized.

dagood commented Feb 21, 2020

dotnet-maestro bot commented Feb 21, 2020 • edited Loading

Auto-Merge Status

wtgodbe commented Feb 21, 2020

dotnet-maestro bot commented Feb 21, 2020

Auto-Merge Status

wtgodbe commented Feb 21, 2020

nguerrera commented Feb 21, 2020

dotnet-maestro bot commented Feb 19, 2020 •

edited

Loading

nguerrera commented Feb 20, 2020 •

edited

Loading

dagood commented Feb 20, 2020 •

edited

Loading

dotnet-maestro bot commented Feb 21, 2020 •

edited

Loading