Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cancel execution command #1057

Closed
wants to merge 44 commits into from
Closed

Adding cancel execution command #1057

wants to merge 44 commits into from

Commits on Feb 23, 2021

  1. move Quit command to Microsoft.DotNet.Interactive and ensure tests fo… 

    …r serialization roundtrip and contract validation
    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b51fbae View commit details
    Browse the repository at this point in the history

  2. move kernel extension to enable quit command

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    91b3a70 View commit details
    Browse the repository at this point in the history

  3. add tests for quit command behaviour

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    262e87f View commit details
    Browse the repository at this point in the history

  4. add changes to contract

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    fc79eb5 View commit details
    Browse the repository at this point in the history

  5. ensure inflight commands are failed on quit

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0e9ee79 View commit details
    Browse the repository at this point in the history

  6. wiring up parent kernel event pump

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    e41a0d7 View commit details
    Browse the repository at this point in the history

  7. add cancel command

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    471e312 View commit details
    Browse the repository at this point in the history

  8. updated typescript contract files

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    8a873c5 View commit details
    Browse the repository at this point in the history

  9. implementing cancel command 

    cancel all active context that are not executing quit or cancel


make sure all commands in the queue are cancelled
    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    73e72b2 View commit details
    Browse the repository at this point in the history

  10. fix file

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    34b41d0 View commit details
    Browse the repository at this point in the history

  11. fix code

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    04bea52 View commit details
    Browse the repository at this point in the history

  12. Update src/Microsoft.DotNet.Interactive.Tests/LanguageKernelTests.cs 

    Co-authored-by: Jon Sequeira <jonsequeira@gmail.com>
    @colombod @jonsequitur
    colombod and jonsequitur committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    bc0a1fa View commit details
    Browse the repository at this point in the history

  13. quit default behaviour throws if not configured

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    24d2669 View commit details
    Browse the repository at this point in the history

  14. update ncrunch settings

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    7ca9c3e View commit details
    Browse the repository at this point in the history

  15. regroup tests for quit command

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    23e1ff7 View commit details
    Browse the repository at this point in the history

  16. split tests

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    925d26a View commit details
    Browse the repository at this point in the history

  17. refactor cancel tests out to specific test class

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    5fd1b21 View commit details
    Browse the repository at this point in the history

  18. timeout on wait

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b770108 View commit details
    Browse the repository at this point in the history

  19. remove unused namespace

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    67b5524 View commit details
    Browse the repository at this point in the history

  20. rebase quit on cancel command

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    fa9b8a7 View commit details
    Browse the repository at this point in the history

  21. reset handler before test

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    60a3853 View commit details
    Browse the repository at this point in the history

  22. reflect changes in contract.ts

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    a282d76 View commit details
    Browse the repository at this point in the history

  23. refactor cancelCommands 

    remove unused methods
    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    2bcc44e View commit details
    Browse the repository at this point in the history

  24. avoid double cancellation request

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b27cc5f View commit details
    Browse the repository at this point in the history

  25. add test to ensure commands are runing after cancel is issued

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    47a35f3 View commit details
    Browse the repository at this point in the history

  26. introduce KernelCommandScheduler

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c43018f View commit details
    Browse the repository at this point in the history

  27. testing scheduler behaviours 

    deferred command that match the kernel used during scheduling of a command are executed


deferred command order is preserved and parent kernel deferred commands are executed when scheduling commands on child kernel


do not produce diagnostic events when there are none


use callable command
    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    77656f1 View commit details
    Browse the repository at this point in the history

  28. experiment

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    16d0d55 View commit details
    Browse the repository at this point in the history

  29. new scheduler api

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    d32c122 View commit details
    Browse the repository at this point in the history

  30. scheduled work must be awaited before completing the source

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    37e9b31 View commit details
    Browse the repository at this point in the history

  31. cleanup

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    7368e0d View commit details
    Browse the repository at this point in the history

  32. cancel work on scheduler

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    50a9bff View commit details
    Browse the repository at this point in the history

  33. refactoring

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    44713b3 View commit details
    Browse the repository at this point in the history

  34. refactor test

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c62ff9b View commit details
    Browse the repository at this point in the history

  35. disable warning for fire and forget

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    87de3ea View commit details
    Browse the repository at this point in the history

  36. removed pragma

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    99b10e1 View commit details
    Browse the repository at this point in the history

  37. disposable scheduler disposed during tests

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    8edf855 View commit details
    Browse the repository at this point in the history

  38. test parallel execution

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    885ab81 View commit details
    Browse the repository at this point in the history

  39. test for parallelism

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    a8c5b86 View commit details
    Browse the repository at this point in the history

  40. test 

    exception handling for code in scheduled work


remove blank lines
    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    2c470e9 View commit details
    Browse the repository at this point in the history

  41. remove namespace

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    314e740 View commit details
    Browse the repository at this point in the history

  42. change api surface

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    d7c3353 View commit details
    Browse the repository at this point in the history

  43. remove extension methods

    @colombod
    colombod committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    682d49c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. all broken here

    @colombod
    colombod committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    88cc568 View commit details
    Browse the repository at this point in the history