move all npm-related stuff to build scripts #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
refactor-build
branch
11 times, most recently
from
e2d72f1 to
b973eb2
Compare
|
This mostly works. For reasons unknown to me, setting At @colombod's request I also added a |
colombod
approved these changes
Nov 20, 2021
brettfo
force-pushed
the
refactor-build
branch
from
b973eb2 to
1127431
Compare
|
Got it all working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change running
build.cmd/./build.shwill donpm iandnpm run compilebeforedotnetis invoked which means the project files could be simplified.This also means the dev instructions can be simplified to just "Run the build script" (pending).
PR marked as draft while I run some internal builds to make sure everything still works, including the
SkipTests=trueflag.N.b., The Linux portion of this PR was done entirely in a Codspaces VM and because of this some devcontainer stuff was updated to make the experience easier.