.dib metadata support #2259
Merged
.dib metadata support #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
dib-metadata-support
branch
from
d80ec92 to
2661bcc
Compare
brettfo
reviewed
Sep 15, 2022
| @@ -0,0 +1,27 @@ | |||
| #!meta | |||
|
|
|||
| {"kernelInfo":{"defaultKernelName":"csharp","items":[{"aliases":["cs","C#","c#"],"name":"csharp"},{"aliases":["fs","F#","f#"],"name":"fsharp"},{"aliases":["powershell"],"name":"pwsh"},{"name":"mermaid"},{"name":"javascript"}]}} | |||
There was a problem hiding this comment.
Can we format/indent this? It's kind-of meaningful to human eyes and if/when this changes, the diff will be more manageable.
There was a problem hiding this comment.
Yes it should work if formatted over multiple lines, but I need to add a test for that.
brettfo
reviewed
Sep 15, 2022
| public string? Language { get; set; } | ||
| public string? KernelName { get; set; } | ||
|
|
||
| // FIX: (InteractiveDocumentElement) add this back |
There was a problem hiding this comment.
Language won't need to be added back; it can be looked up via the metadata.
There was a problem hiding this comment.
Do you mean kernel info? The goal here is to not have to spin up the kernel in order to know some of these things.
|
The bottom of |
colombod
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2184.