-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to jupyter kernels #2791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge main
…is is a "release/" branch Eng/common changes will be the same in next arcade update from the release/7.0 branch if/when this is taken.
main to release/jupyter branch
merge main
merge main to release/jupyter
Merge `main` to `release/jupyter`
…n and add kernel info to the proxy kernel.
…w language specific handling.
…d with the ansi encoding.
…alue handler on kernel info retrurned. R value support needs more work.
… handle get value and valueinfo now
… use this for kernel variable sharing and not for kernel initialization.
…ince the change applies to kernel variable sharing initialization, it impacts all tests.
…he Command Options
…e directory under jupyter folder until jupyter actually runs.
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
reviewed
Apr 5, 2023
jonsequitur
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
shibbas
commented
Apr 7, 2023
shibbas
commented
Apr 7, 2023
throw new ArgumentNullException(nameof(kernelSpecModule)); | ||
} | ||
|
||
_getKernelSpecs = Task.Run(() => kernelSpecModule.ListKernels()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to revisit this design to support the cold start scenario.
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables connecting to Jupyter kernels via the
#!connect jupyter
command and interact with them to perform the following:SubmitCode
,RequestCompletions
,RequestSignatureHelp
,RequestHoverText
SendValue
,RequestValue
andRequestValueInfos
command.This currently does not support selecting environment yet. vscode will need to start in the environment with Jupyter installed.
Known issues: