port localization to stable #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
requested review from
ocallesp,
shyamnamboodiripad,
AbhitejJohn and
brettfo
colombod
commented
May 3, 2023
colombod
commented
May 3, 2023
colombod
force-pushed
the
lockalization_stable
branch
from
ace0f0f to
41191d9
Compare
colombod
force-pushed
the
lockalization_stable
branch
from
41191d9 to
1a8e6a5
Compare
AbhitejJohn
reviewed
May 4, 2023
| @@ -36,6 +36,12 @@ try { | |||
| Remove-Item -Path "$stableDirectory\src\*" -Filter "*.ts" | |||
| Copy-Item -Path "$insidersDirectory\src\*" -Destination "$stableDirectory\src\" -Filter "*.ts" | |||
|
|
|||
| # copy localization files | |||
There was a problem hiding this comment.
Quick question: So if we have this in the script, do we still need the package.nls.*.json files below? Looks like they exist here: https://github.com/dotnet/interactive/tree/main/src/polyglot-notebooks-vscode-insiders
There was a problem hiding this comment.
package.nls.*.json should override the existing ones to keep in sync with the ones in insiders
ocallesp
approved these changes
May 5, 2023
| @@ -841,6 +841,6 @@ | |||
| "vscode-oniguruma": "1.6.1", | |||
| "vscode-textmate": "6.0.0", | |||
| "vscode-uri": "3.0.6", | |||
| "@vscode/l10n": "^0.0.10" | |||
| "@vscode/l10n": "0.0.10" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
"l10n": "./l10n" needs to be added to package.json like in insiders in order to recognize the strings in l10n\bungle.l10n.json
There was a problem hiding this comment.
the release branch has that change already
|
Polyglot-notebooks-vscode Testing English |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.