handling number literals in value sharing #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
colombod
commented
Jun 19, 2023
•
colombod
commented
17 tasks
jonsequitur
reviewed
Jun 19, 2023
|
|
||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Needs cleanup or is this unfinished code?
jonsequitur
reviewed
Jun 19, 2023
| return Infinity; | ||
| } else if (value === "-Infinity") { | ||
| return -Infinity; | ||
| } else if (value === "NaN") { |
There was a problem hiding this comment.
Micro-optimization micro-nitpick: NaN will be by far the most common case here and might should be checked before the others.
jonsequitur
reviewed
Jun 19, 2023
| } | ||
| return value; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can we consolidate these multiple copies of the same logic?
colombod
force-pushed
the
NaN_serialization
branch
from
d50943e to
de81401
Compare
jonsequitur
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.