Perf improvements for CSharpProjectKernel #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
approved these changes
Jul 1, 2024
| @@ -24,7 +23,7 @@ public abstract class WorkspaceServerTestsCore : IDisposable | |||
| ITestOutputHelper output) | |||
| { | |||
| _prebuildFixture = prebuildFixture; | |||
| _disposables.Add(output.SubscribeToPocketLogger()); | |||
| // _disposables.Add(output.SubscribeToPocketLogger()); | |||
There was a problem hiding this comment.
Should this be uncommented? Can this be deleted if it not needed?
| metadataReferences: GetMetadataReferences(projectBuildInfo), | ||
| analyzerReferences: GetAnalyzerReferences(projectBuildInfo, workspace), | ||
| analyzerReferences: null, |
There was a problem hiding this comment.
Is this intentional? Are we ignoring analyzers because while analyzers can block build for projects that otherwise compile, the opposite is not true (i.e. analyzers can't cause projects that fail to build because of other build failures to build successfully)?
There was a problem hiding this comment.
Analyzers are not supported for security reasons.
jonsequitur
added
Area-Try .NET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.