Changes to header parsing #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Sep 17, 2024
Co-authored-by: Jon Sequeira <jonsequeira@gmail.com>
shyamnamboodiripad
approved these changes
Sep 17, 2024
jonsequitur
reviewed
Sep 18, 2024
jonsequitur
reviewed
Sep 18, 2024
jonsequitur
reviewed
Sep 18, 2024
jonsequitur
reviewed
Sep 18, 2024
jonsequitur
reviewed
Sep 18, 2024
|
|
||
| var returnValue = secondResult.Events.OfType<ReturnValueProduced>().First(); | ||
|
|
||
| var response = (HttpResponse)returnValue.Value; |
There was a problem hiding this comment.
It doesn't looks like returnValue or response are needed.
jonsequitur
reviewed
Sep 18, 2024
|
|
||
| var returnValue = secondResult.Events.OfType<ReturnValueProduced>().First(); | ||
|
|
||
| var response = (HttpResponse)returnValue.Value; |
There was a problem hiding this comment.
It doesn't looks like returnValue or response are needed.
jonsequitur
reviewed
Sep 18, 2024
src/Microsoft.DotNet.Interactive.Http.Tests/HttpKernelTests.NamedRequest.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Sep 18, 2024
| { | ||
| var response = new HttpResponseMessage(HttpStatusCode.OK); | ||
| response.RequestMessage = message; | ||
| var contentString = @" |
There was a problem hiding this comment.
Using a raw string (""") will improve readability.
jonsequitur
reviewed
Sep 18, 2024
src/Microsoft.DotNet.Interactive.Http.Tests/HttpKernelTests.NamedRequest.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Sep 18, 2024
src/Microsoft.DotNet.Interactive.Http.Tests/HttpKernelTests.NamedRequest.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Sep 18, 2024
src/Microsoft.DotNet.Interactive.Http.Tests/HttpKernelTests.NamedRequest.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Sep 18, 2024
jonsequitur
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with trying to get values from the headers of an http response. It looks to see if the user has a path of four, assuming they want the first element in the list and if there's a path of five then it gets the first element in the list that matches the value of the string. Additionally, a test for this scenario is included.