properly reject failed language service calls #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a language service call fails, it can leave the VS Code UI forever in a
Loading...state. An example of this is trying to invoke hover text for F# code. The command expectedly fails due to aNoSuitableKernelFoundException(because F# currently doesn't provide hover text), but that failure is never propagated to the UI.The fix is to actually call
reject()if the call failed.This addresses the real underlying problem mentioned in #736, and #714 will add hover text for F#.
Without this change, the failure would bubble all the way to the top of the JS engine and manifest itself in the console.
The real change is the addition of the
ensureErrorsAreRejected()function; the rest is just copy/paste.