Skip to content

Commit

Permalink
A few more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pgrawehr committed Feb 22, 2021
1 parent 176694e commit 22b35ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/devices/Arduino/ArduinoGpioControllerDriver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ protected override PinMode GetPinMode(int pinNumber)
ret = PinMode.Input;
break;
default:
_arduinoBoard.Log($"Unexpected pin mode found: {mode}. Is the pin not set to GPIO?");
ret = PinMode.Input; // TODO: Return "Unknown"
break;
}
Expand Down Expand Up @@ -136,7 +137,7 @@ protected override bool IsPinModeSupported(int pinNumber, PinMode mode)

protected override PinValue Read(int pinNumber)
{
return _arduinoBoard.Firmata.GetDigitalPinState(pinNumber);
return _arduinoBoard.Firmata.ReadDigitalPin(pinNumber);
}

protected override void Write(int pinNumber, PinValue value)
Expand Down
2 changes: 1 addition & 1 deletion src/devices/Arduino/FirmataDevice.cs
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ internal void EnableDigitalReporting()
}
}

public PinValue GetDigitalPinState(int pinNumber)
public PinValue ReadDigitalPin(int pinNumber)
{
lock (_lastPinValueLock)
{
Expand Down

0 comments on commit 22b35ec

Please sign in to comment.