New Device: LED segment display 5641AS #2350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
area-device-bindings
|
@dotnet-policy-service agree |
jabberhams
commented
Aug 29, 2024
Ellerbach
reviewed
Aug 30, 2024
| /// <summary> | ||
| /// Opens GPIO pins defined in <see cref="LedSegmentDisplay5641ASPinScheme"/> as <see cref="PinMode.Output"/> | ||
| /// </summary> | ||
| public void Open() |
There was a problem hiding this comment.
Why do you have the Open and Close functions? Can Open be done in the constructor and Close in the Dispose? So it's really fully transparent for the user?
You can keep the function and use them but then change the visibility in private in that case.
I may have miss something why you need an Open and Close as public
There was a problem hiding this comment.
No reason, just carryover from testing. I will make the changes.
| public int NumberOfDigits => _pinScheme.DigitCount; | ||
|
|
||
| /// <inheritdoc /> | ||
| public Segment this[int address] { get => throw new NotImplementedException(); set => throw new NotImplementedException(); } |
There was a problem hiding this comment.
is there any way to recreate a Segment? So that it's make easy for the user and kind of easier?
| @@ -1,10 +1,14 @@ | |||
| # HT16K33 - LED Matrix Display Driver | |||
| # LED Displays | |||
There was a problem hiding this comment.
Suggested change
| # LED Displays | |
| # LED Displays - 5641AS, HT16K33 and LED Matrix Display Driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New device
LedSegmentDisplay5641ASadded. The device has fewer display characteristics (no colon or degrees) and while other devices in the Display category were driven by backpacks over I2C, this code is full GPIO only. In addition to the device, a dedicated pin schemeLedSegmentDisplay5641ASPinSchemeis for mapping board pins to device pins, and a helper class translatesFonts to segment assignments. Readme also updated.My first contribution so looking for constructive feedback where necessary.
Microsoft Reviewers: Open in CodeFlow