-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WS2812B binding #241
Add WS2812B binding #241
Conversation
Please move these two files under src/devices/Common/BitmapImage.cs and also change the namespace so that it is like: |
Also, can you please add the liscensing headers into these two files as well? |
These samples project should instead live under the binding you added in a samples folder. You can check all of our existing bindings for examples, but basically what we require for a binding is: a project under |
Hey @maloo, thanks for your contribution! I left some initial comments on the PR, in order to produce the right layout/structure we are looking for in a binding, would you mind either copying the structure of an existing binding or using the steps outlined here in order to create your binding project using our CLI template? That should help you get started without having to deal with the rest of our infrastructure 😉 |
Hey @maloo thanks for contributing, couple of comments (mostly naming and layout) other than that looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @maloo!
fixes: #170
cc: @krwq @joperezr