Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WS2812B binding #241

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Add WS2812B binding #241

merged 7 commits into from
Feb 19, 2019

Conversation

maloo
Copy link
Contributor

@maloo maloo commented Feb 17, 2019

fixes: #170
cc: @krwq @joperezr

@dnfclas
Copy link

dnfclas commented Feb 17, 2019

CLA assistant check
All CLA requirements met.

@joperezr
Copy link
Member

joperezr commented Feb 17, 2019

Refers to: src/Iot.Device.Bindings/Utils/BitmapImage.cs

Please move these two files under src/devices/Common/BitmapImage.cs and also change the namespace so that it is like: Iot.Device.Common

@joperezr
Copy link
Member

joperezr commented Feb 17, 2019

Refers to: src/Iot.Device.Bindings/Utils/BitmapImage.cs

Also, can you please add the liscensing headers into these two files as well?

@joperezr
Copy link
Member

joperezr commented Feb 17, 2019

Refers to: samples/neo-pixels-x8/neo-pixels-x8.csproj

These samples project should instead live under the binding you added in a samples folder. You can check all of our existing bindings for examples, but basically what we require for a binding is: a project under src/devices/<yourBinding>/ folder, and a Readme.md with information on the binding(again, you can check all of our existing bindings' Readme files for the content that should go in it). Then we also ask for a samples folder containing a sample project with the usage of your binding, along with another readme containing both a fritzing diagram and an explanation of what the samples would do and how to wire it. Seems like the samples contents you have here is right, so you just need to move it under the binding.

@joperezr
Copy link
Member

joperezr commented Feb 17, 2019

Hey @maloo, thanks for your contribution! I left some initial comments on the PR, in order to produce the right layout/structure we are looking for in a binding, would you mind either copying the structure of an existing binding or using the steps outlined here in order to create your binding project using our CLI template? That should help you get started without having to deal with the rest of our infrastructure 😉

@krwq
Copy link
Member

krwq commented Feb 17, 2019

Hey @maloo thanks for contributing, couple of comments (mostly naming and layout) other than that looks good!

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maloo!

@krwq krwq merged commit 5dd3350 into dotnet:master Feb 19, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bindings for E466616 (NeoPixel Stick - 8x 5050 RGB LED with integrated driver)
4 participants