Bindingsgenerator: Callback interface with variadic arguments generates incorrect code

[maksimorlovich]

We have a class like this in our project jar:

package com.xamarin;

public class MyPublicClass extends MyPackageClass {
    public interface Listener {
        void call(Object... args);
    }

    @Override
    public void bugOne() {
    }

    public void bugTwo(Listener listener) {
        listener.call("abc", "def", new Integer(5));
    }
}

The C# code generated for bugTwo method and callback interface is like this:

public partial class EventArgs : global::System.EventArgs {
			public EventArgs (params global:: Java.Lang.Object[] p0)
			{
				this.p0 = p0;
			}

			params global:: Java.Lang.Object[] p0;
			public params global:: Java.Lang.Object[] P0 {
				get { return p0; }
			}
		}

It converts variadic arguments to array of Object which is fine, but it mistakenly carries through the params declaration which is invalid for member variables and return types.

This bug reproduces with Visual Studio for Mac community edition 2017 and I also built from source the generator.exe and it still repros the problem. I'm attaching a jar which shows the bug. Just create a new visual studio android binding library project and add the attached jar, build, and observe the error.
libxamarinbug.jar.zip

[jpobst]

It looks like this was fixed a while ago, most likely in #263.

Here is what the attached test case generates now:

// event args for com.xamarin.MyPublicClass.Listener.call
public partial class EventArgs : global::System.EventArgs {

	public EventArgs (params global::Java.Lang.Object[] p0)
	{
		this.p0 = p0;
	}

	global::Java.Lang.Object[] p0;
	public global::Java.Lang.Object[] P0 {
		get { return p0; }
	}
}