Skip to content

[JavaTypeSystem] Add JavaFieldModel.ToString (). #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Sep 14, 2023

Context: https://discord.com/channels/732297728826277939/732297837953679412/1151531791069499524

A user reported the following output in their java-resolution-report.log:

The field 'Java.Interop.Tools.JavaTypeSystem.Models.JavaFieldModel' was removed because its name contains a dollar sign.
The class '[Class] com.google.android.libraries.navigation.internal.aac.ad' was removed because the Java base type 'com.google.android.libraries.navigation.internal.aad.ar<com.google.android.libraries.navigation.internal.aac.af<K, V>>' could not be found.

We should be providing the user with the name of the removed field rather than the JavaFieldModel type name. To do this, add an appropriate JavaFieldModel.ToString ().

@jpobst jpobst marked this pull request as ready for review September 14, 2023 14:17
@jpobst jpobst requested a review from jonpryor September 14, 2023 14:17
@jonpryor jonpryor merged commit 75d8221 into main Sep 14, 2023
@jonpryor jonpryor deleted the field-tostring branch September 14, 2023 23:49
jonpryor pushed a commit to dotnet/android that referenced this pull request Sep 21, 2023
Changes: dotnet/java-interop@5bb0d24...75d8221

  * dotnet/java-interop@75d8221d: [JavaTypeSystem] Add JavaFieldModel.ToString(). (dotnet/java-interop#1144)
  * dotnet/java-interop@eac0d581: Bump to xamarin/xamarin-android-tools/main@9c50a2d (dotnet/java-interop#1140)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants