Bump external/xamarin-android-tools from ed102fc to a698a33
#1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [external/xamarin-android-tools](https://github.com/xamarin/xamarin-android-tools) from `ed102fc` to `a698a33`. - [Commits](dotnet/android-tools@ed102fc...a698a33) --- updated-dependencies: - dependency-name: external/xamarin-android-tools dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
jonpryor
deleted the
dependabot/submodules/external/xamarin-android-tools-a698a33
branch
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Feb 9, 2024
Changes: dotnet/java-interop@7f08b77...dfcbd67 * dotnet/java-interop@dfcbd670: Bump to xamarin/xamarin-android-tools/main@a698a33 (dotnet/java-interop#1189) * dotnet/java-interop@6182baff: [build] Target `net8.0` (dotnet/java-interop#1186) dotnet/java-interop@6182baff updated Java.Interop to target .NET 8 instead of .NET 7. This introduced a build break: …/xamarin-android/src/Mono.Android/Mono.Android.csproj(402,5): error MSB3030: Could not copy the file "…/xamarin-android/external/Java.Interop/bin/Debug-net7.0/ref/Java.Interop.dll" because it was not found. Introduce a new `$(JavaInteropTargetFrameworkVersion)` MSBuild property within `Configuration.props` which contains the .NET version that Java.Interop is targeting. Update `Mono.Android.csproj` and `Microsoft.Android.Ref.proj` so that they use `$(JavaInteropTargetFrameworkVersion)` to locate the reference `Java.Interop.dll` assembly.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Feb 9, 2024
Changes: dotnet/java-interop@7f08b77...dfcbd67 * dotnet/java-interop@dfcbd670: Bump to xamarin/xamarin-android-tools/main@a698a33 (dotnet/java-interop#1189) * dotnet/java-interop@6182baff: [build] Target `net8.0` (dotnet/java-interop#1186) dotnet/java-interop@6182baff updated Java.Interop to target .NET 8 instead of .NET 7. This introduced a build break: …/xamarin-android/src/Mono.Android/Mono.Android.csproj(402,5): error MSB3030: Could not copy the file "…/xamarin-android/external/Java.Interop/bin/Debug-net7.0/ref/Java.Interop.dll" because it was not found. Introduce a new `$(JavaInteropTargetFrameworkVersion)` MSBuild property within `Configuration.props` which contains the .NET version that Java.Interop is targeting. Update `Mono.Android.csproj` and `Microsoft.Android.Ref.proj` so that they use `$(JavaInteropTargetFrameworkVersion)` to locate the reference `Java.Interop.dll` assembly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps external/xamarin-android-tools from
ed102fctoa698a33.Commits
a698a33Merge pull request #227 from xamarin/dev/jestedfa/uses-sdk8b13954Added unit tests84c2911Only conditionally include <uses-sdk /> in the AndroidManifest.xml when savingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)