[build] fix usage of /p:CscToolExe=which mcs
#511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://build.azdo.io/3182458 Our build is currently failing with: (CoreCompile target) -> CSC : error CS1617: Invalid -langversion option `7.3'. It must be `ISO-1', `ISO-2', Default, Latest or value in range 1 to 7.2 I think this is due to: /p:CscToolExe=`which mcs` We need to use `mcs`, because `gendarme` does not yet support portable `.pdb` files. However, it also appears that it does not support C# 7.2. If we set `/p:LangVersion=Default`, it may select a usable C# version. Things might continue to work as long as we don't use a C# 7.3 feature. Then we got to the next failure: (CoreCompile target) -> Microsoft.CSharp.Core.targets(59,5): error : error CS2001: Source file `/analyzerconfig:/Users/runner/runners/2.159.2/work/1/s/.editorconfig' could not be found The error is a little misleading, basically `mcs` does not understand the `/analyzerconfig` switch. So it is trying to treat it as a source code file. I found the source code for this here: https://github.com/dotnet/roslyn/blob/6fc75491954be7ddff8c489a4ff424b3524ae80f/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L63 So we can add `/p:DiscoverEditorConfigFiles=False` to ignore `.editorconfig` files.
jonathanpeppers
force-pushed
the
gendarme-langversion
branch
from
dbc31d8 to
6626f95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://build.azdo.io/3182458
Our build is currently failing with:
I think this is due to:
We need to use
mcs, becausegendarmedoes not yet support portable.pdbfiles. However, it also appears that it does not support C# 7.2.If we set
/p:LangVersion=Default, it may select a usable C# version.Things might continue to work as long as we don't use a C# 7.3
feature.
Then we got to the next failure:
The error is a little misleading, basically
mcsdoes not understandthe
/analyzerconfigswitch. So it is trying to treat it as a sourcecode file.
I found the source code for this here:
https://github.com/dotnet/roslyn/blob/6fc75491954be7ddff8c489a4ff424b3524ae80f/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L63
So we can add
/p:DiscoverEditorConfigFiles=Falseto ignore.editorconfigfiles.