[param-name-importer] Fix crash trying to modify a Dictionary.Values collection directly #807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #756, we switched from using
List<JavaPackage>
toDictionary<string, JavaPackage>
for better performance. To minimize the diffs needed with existing code, we created an accessor for theDictionary.Values
:However if you attempt to modify this collection directly, you get an exception.
Thus we need to update this code that adds to the collection to use the dictionary properly.
Also verified that this is the only code that attempts to write to
AllPackages
.