Suppress warning if UnconditionalSuppressMessageAttribute is used #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoatr
reviewed
Mar 15, 2021
|
|
||
| internal static bool IsDiagnosticSuppressed(OperationAnalysisContext operationContext, string diagnosticId) | ||
| { | ||
| var attributes = operationContext.ContainingSymbol.GetAttributes(); |
There was a problem hiding this comment.
Will this work when the suppression is up in the tree?
e.g.
[UnconditionalSuppressMessage ("", "IL1234:MyWarning")]
class Foo {
void Bar () {
// Triggers warning IL1234
}
}There was a problem hiding this comment.
Right, this only handles local suppression. Global suppression support will have to be added in another PR.
mateoatr
reviewed
Mar 15, 2021
|
As far as I can tell, the Target property is only relevant on attributes higher than the member level. |
|
I'm gonna close this for now, since it looks like the Roslyn change is gonna go through. |
|
Closing in favor of dotnet/roslyn#51792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If/when Roslyn ships a universal suppress behavior here we can remove this code.