Fix delegate conversion on analyzers #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests
Youssef1313
reviewed
Apr 15, 2021
Youssef1313
reviewed
Apr 15, 2021
…rDelegateConversion
agocke
reviewed
Apr 20, 2021
| @@ -72,6 +72,12 @@ public override void Initialize (AnalysisContext context) | |||
| CheckMethodOrCtorCall (operationContext, prop.SetMethod); | |||
| }, OperationKind.PropertyReference); | |||
|
|
|||
| context.RegisterOperationAction (operationContext => { | |||
There was a problem hiding this comment.
This diff makes me think we need to share more between the two analyzers. They look like they're doing pretty much exactly the stuff.
| @@ -352,5 +352,52 @@ public void M() | |||
|
|
|||
| return VerifyRequiresAssemblyFilesAnalyzer (src); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Same with the tests. Can we start to share stuff here?
There was a problem hiding this comment.
I open #1986 to track the refactoring work in a separate PR since I think it would have a lot of feedback.
Fix test Add number of iterations to codefix
agocke
reviewed
Apr 24, 2021
test/ILLink.RoslynAnalyzer.Tests/RequiresUnreferencedCodeAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
agocke
approved these changes
Apr 24, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Fix delegate conversion on analyzers Fix test in RequiresUnreferencedCodeAnalyzer Add tests for delegate conversion Add the ability to pass the number of iterations in a codefix Commit migrated from dotnet/linker@7ddfe7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix delegate conversion on analyzers
Add tests
Related to #1912