LinkContext.UserAction defaults to AssemblyAction.Link #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 4d2362d [broke the xamarin-android linker][0], as assemblies which should have been linked were no longer being linked. [0]: dotnet/android#1112 (comment) The apparent cause is that before commit 4d2362d, the "default" action would be `AssemblyAction.Link`. Starting with 4d2362d, the default action was instead `AssemblyAction.Skip`, as `LinkContext._userAction` would be zero-initialized during construction, and `AssemblyAction.Skip` is the default (0) enum value. Set `AssemblyAction._userAction` in the constructor to `AssemblyAction.Link`, so that pre-4d2362d8 linker behavior is retained. This should allow the Xamarin.Android linker to work without further changes.
Contributor
|
This value is correctly initialized by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 4d2362d broke the xamarin-android linker, as assemblies
which should have been linked were no longer being linked.
The apparent cause is that before commit 4d2362d, the "default"
action would be
AssemblyAction.Link. Starting with 4d2362d, thedefault action was instead
AssemblyAction.Skip, asLinkContext._userActionwould be zero-initialized duringconstruction, and
AssemblyAction.Skipis the default (0) enum value.Set
AssemblyAction._userActionin the constructor toAssemblyAction.Link, so that pre-4d2362d8 linker behavior isretained. This should allow the Xamarin.Android linker to work without
further changes.