Upgrade Microsoft.IO.Redist #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM, thanks. In general I wonder if we should be using a MicrosoftBuildFrameworkVersion matching dotnet/sdk, instead of bumping to the latest MSBuild and then having to fix up the transitive dependencies when there are cg alerts, similar to what I suggested in #3187 (comment).
|
I think that makes sense for 8.0, but for 6.0 a targeted fix seems appropriate and low risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.