Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify solutions used to build monolinker/illink #474

Merged
merged 6 commits into from
Feb 26, 2019

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 25, 2019

Until I can make more progress on SDK-style projects (see #471), I'll begin trying to set up a build of illink using arcade and the old-style projects. In this change I'm getting rid of the scattered linker.sln files in favor of monolinker.sln for monolinker, and illink.sln for the illink/ILLink.Tasks build.

@sbomer sbomer requested a review from marek-safar as a code owner February 25, 2019 17:37
@sbomer
Copy link
Member Author

sbomer commented Feb 25, 2019

build

@sbomer
Copy link
Member Author

sbomer commented Feb 25, 2019

@marek-safar the Linux - Mono build definition is failing because of the solution rename. What does it take to update the build definition?

@marek-safar
Copy link
Contributor

@akoeplinger I think we need to update it on Jenkins, right?

@akoeplinger
Copy link
Member

should be fixed.

@monojenkins build

@marek-safar marek-safar merged commit 1331119 into dotnet:master Feb 26, 2019
@sbomer sbomer deleted the illinkSln branch March 26, 2019 16:08
tkapin pushed a commit to tkapin/runtime that referenced this pull request Jan 31, 2023
Until I can make more progress on SDK-style projects (see dotnet/linker#471), I'll begin trying to set up a build of illink using arcade and the old-style projects. In this change I'm getting rid of the scattered linker.sln files in favor of monolinker.sln for monolinker, and illink.sln for the illink/ILLink.Tasks build.

Commit migrated from dotnet/linker@1331119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants