Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Eh fixes #890

Merged
merged 3 commits into from
Oct 14, 2015
Merged

Eh fixes #890

merged 3 commits into from
Oct 14, 2015

Conversation

JosephTremoulet
Copy link
Contributor

Note: this is a PR for changes to go into the EH branch

Fix three small bugs that prevent mscorlib from compiling cleanly.

@JosephTremoulet
Fix typo causing infinite loop
4572885 
When insertConditionalPointBlock inserts a point block that has been
split, it needs to find the ultimate tail point block, not keep checking
the head point block's terminator repeatedly.
@JosephTremoulet
Fix for callRuntimeHandleHelper in try regions
3856a25 
The helper call may be an invoke, so the predecessor of the PHI block may
not be the block holding the call, but rather it's invoke's normal
successor.
@JosephTremoulet
Set correct context for new IR in readerPostVisit
1e9398e 
Make sure that CurrentInstrOffset and CurrentRegion have reasonable values
when inserting prolog code after parsing all instructions (previously they
were inadvertently getting the end-of-function values).
@JosephTremoulet
Copy link
Contributor Author

@AndyAyersMS or @pgavlin PTAL

@AndyAyersMS
Copy link
Member

LGTM

JosephTremoulet added a commit that referenced this pull request Oct 14, 2015
@JosephTremoulet
Merge pull request #890 from JosephTremoulet/EhFixes
325416b 
Eh fixes
@JosephTremoulet JosephTremoulet merged commit 325416b into dotnet:EH Oct 14, 2015
@JosephTremoulet JosephTremoulet deleted the EhFixes branch October 14, 2015 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JosephTremoulet @AndyAyersMS @dnfclas