Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of Code Documentation #160

Closed
TomFinley opened this issue May 15, 2018 · 7 comments
Closed

Migration of Code Documentation #160

TomFinley opened this issue May 15, 2018 · 7 comments
Assignees
Labels
documentation Related to documentation of ML.NET P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@TomFinley
Copy link
Contributor

TomFinley commented May 15, 2018

There have been many questions both in issues and PRs that could have been addressed with some existing as-yet unmigrated documentation. (Not all questions, but a significant number.) People are curious, that's great.

Note that this is not MSDN-style API documentation, but more ad hoc documents. I believe there is a shared understanding that documents like this, not MSDN-style docs but the more ad hoc docs, should be checked in next to the code. Let me know if not.

This will not be a straight copy job though and should be done with due care, for the following reasons:

  1. some docs refer to the prior internal name for ML.NET (though to be fair I've noticed the code does too in places 😛) so that ought to be changed,
  2. it appeals to historical perspectives or prior states of code that are invisible to people, which is awkward. This is hard, you can't just delete that stuff, because the point of the code docs is to explain exactly why something is engineered in a certain way, and that discussion is helped enormously if you explain why a deceptively "easier" way of doing task X, Y, or Z was deemed unacceptable.
  3. it sometimes contextualizes the presence of this or that aspect of the code as being something that exists to solve an existing use-case, and not all those use-cases are open sourced.
  4. While much of it is already in .md, some older docs are in other formats and will require some attention to migrate them.

Would appreciate discussion from @asthana86 , @eerhardt , @GalOshri , @glebuk , and @shauheen specifically on this topic. (To clarify all are welcome, just mentioning to make sure it gets flagged for them. 😄)

@shauheen shauheen added the documentation Related to documentation of ML.NET label May 15, 2018
@shauheen shauheen added this to the 0518 milestone May 15, 2018
@glebuk
Copy link
Contributor

glebuk commented May 15, 2018

Sounds good. Let's start with the IDV and IDV type system docs at the very least. Later one we could add the rest.

@markusweimer markusweimer changed the title Migration of Code Documenation Migration of Code Documentation May 16, 2018
@GalOshri
Copy link
Contributor

This is great.

Additionally, it would be nice to include some additional information on how learners and transforms work in ML.NET (using the contribution tutorials). Although these can be migrated after the core IDV docs.

@TomFinley
Copy link
Contributor Author

TomFinley commented May 17, 2018

Hi @GalOshri ... I'm sorry to say I won't make you happy on the tutorials. While I agree that they're practically quite useful in that it is one of the few things to treat in (excruciating) detail exactly how one goes about writing a component and how our infrastructure works from beginning to bitter end, that one will require considerably more work to adapt, because of course I am throughout the tutorial relying on existing idioms for invoking these, that are not true in the "new" ML.NET API. (And that are under considerable flux, so even if I were to phrase it in those terms, I don't have enormous confidence they will remain relevant.)

@GalOshri
Copy link
Contributor

Thanks @TomFinley! I think it's fine if they are not migrated immediately, but we should try to do that once there is a little less flux.

justinormont pushed a commit that referenced this issue May 22, 2018
Migration of some existing internal documentation, rephrased in some places to be more appropriate in context (hopefully successfully). Related to #160, though this PR would be just part of addressing the issue of moving over internal docs.
@shauheen shauheen modified the milestones: 0518, 0618 May 30, 2018
@shauheen shauheen modified the milestones: 0618, 0718 Jul 5, 2018
eerhardt pushed a commit to eerhardt/machinelearning that referenced this issue Jul 27, 2018
Migration of some existing internal documentation, rephrased in some places to be more appropriate in context (hopefully successfully). Related to dotnet#160, though this PR would be just part of addressing the issue of moving over internal docs.
@shauheen shauheen removed this from the 0718 milestone Aug 4, 2018
@JRAlexander
Copy link

You could also migrate these to the dotnet/docs machinelearning repo. This would have several advantages, including rendering in Docs.microsoft.com, localization, and editing.

@shmoradims shmoradims added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label May 21, 2019
@shmoradims
Copy link

shmoradims commented May 21, 2019

Related to (possible duplicate of) #1831

@codemzs
Copy link
Member

codemzs commented Jun 30, 2019

closing since it is a duplicate of #1831

@codemzs codemzs closed this as completed Jun 30, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

No branches or pull requests

7 participants