Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should entry-points respect HideEnumValueAttribute information? #341

Closed
TomFinley opened this issue Jun 9, 2018 · 0 comments
Closed

Should entry-points respect HideEnumValueAttribute information? #341

TomFinley opened this issue Jun 9, 2018 · 0 comments

Comments

@TomFinley
Copy link
Contributor

The HideEnumValueAttribute is currently only respected by the command line help tool. Here is an example of it:

[HideEnumValue]
Def = DefaultValue,
[HideEnumValue]
Default = DefaultValue,
[HideEnumValue]
Min = Minimum,
[HideEnumValue]
Max = Maximum,

Yet in the entry-point manifest I see is polluted with these shorter forms. I feel like these probably ought to be suppressed here during manifest generation as well.

"Name": "ReplaceWith",
"Type": {
"Kind": "Enum",
"Values": [
"Default",
"Def",
"DefaultValue",
"Mean",
"Minimum",
"Min",
"Maximum",
"Max"
]

Also the entry-point based API is affected by the same issue, of course.

Default = 0,
Def = 0,
DefaultValue = 0,
Mean = 1,
Minimum = 2,
Min = 2,
Maximum = 3,
Max = 3

@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant