Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble to it's own package #2718

Merged
merged 4 commits into from
Feb 27, 2019
Merged

Ensemble to it's own package #2718

merged 4 commits into from
Feb 27, 2019

Conversation

Ivanidzo4ka
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka commented Feb 25, 2019 •
edited
Loading

fix #2717

eerhardt
eerhardt reviewed Feb 25, 2019
View reviewed changes
src/Microsoft.ML.Ensemble/Microsoft.ML.Ensemble.csproj
@@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML</IncludeInPackage>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this assembly go in a different nuget package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there aren't any public types in this assembly....?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have way to mark stable nugets vs experimental?
It's needed by NimbusML, but in same time, it feels weird to create nuget with zero public surface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t have it yet. But #2279 will enable it. For now let’s make the new package and we can mark it experimental when we have that.

Btw We are creating a Parquet package now, but we don’t ship it.

@Ivanidzo4ka
Copy link
Contributor Author

We discuss and decided to leave it as it is for right now.

@eerhardt eerhardt reopened this Feb 26, 2019
@eerhardt
Copy link
Member

I don't think the way it is right now is correct. Why are we shipping this assembly in the core nuget package?

eerhardt
eerhardt previously approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this in.

@TomFinley
Copy link
Contributor

TomFinley commented Feb 26, 2019 •
edited
Loading

We discuss and decided to leave it as it is for right now.

Sorry, who discussed @Ivanidzo4ka ? Where? I think we need a new nuget to capture this. This would be the ensemble nuget, and it would be marked as experimental per #2279.

@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #2718 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2718      +/-   ##
==========================================
- Coverage   71.66%   71.51%   -0.16%     
==========================================
  Files         808      808              
  Lines      142253   142364     +111     
  Branches    16138    16121      -17     
==========================================
- Hits       101950   101806     -144     
- Misses      35864    36124     +260     
+ Partials     4439     4434       -5
Flag Coverage Δ
#Debug 71.51% <ø> (-0.16%) ⬇️
#production 67.72% <ø> (-0.2%) ⬇️
#test 85.83% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
...OnnxTransformer.StaticPipe/OnnxStaticExtensions.cs 0% <0%> (-100%) ⬇️
....DnnImageFeaturizer.AlexNet/AssemblyPathHelpers.cs 0% <0%> (-100%) ⬇️
...L.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs 0% <0%> (-100%) ⬇️
...r.StaticPipe/DnnImageFeaturizerStaticExtensions.cs 0% <0%> (-100%) ⬇️
....ML.OnnxTransformer/DnnImageFeaturizerTransform.cs 0% <0%> (-95.24%) ⬇️
src/Microsoft.ML.OnnxTransformer/OnnxCatalog.cs 25% <0%> (-75%) ⬇️
src/Microsoft.ML.OnnxTransformer/OnnxTransform.cs 58.38% <0%> (-27.86%) ⬇️
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 67.01% <0%> (-10.31%) ⬇️
...soft.ML.Data/DataView/DataViewConstructionUtils.cs 78.07% <0%> (-7.09%) ⬇️
...L.Data/DataLoadSave/Text/TextLoaderSaverCatalog.cs 96.07% <0%> (-3.93%) ⬇️
... and 154 more

@Ivanidzo4ka Ivanidzo4ka changed the title Remove Ensemble from Microsoft.ML nuget Ensemble and FastTree to their own packages Feb 26, 2019
@eerhardt eerhardt dismissed their stale review February 27, 2019 00:14

New Changes are not approved

@eerhardt
Copy link
Member

@Ivanidzo4ka - can you just keep this PR to be for Ensemble? We can do the FastTree work separate. There is also the native library that needs to move out of Microsoft.ML. I'd feel more comfortable to do Ensemble first. FastTree separate.

@Ivanidzo4ka Ivanidzo4ka changed the title Ensemble and FastTree to their own packages Ensemble to it's own package Feb 27, 2019
@Ivanidzo4ka
Copy link
Contributor Author

Sure

In reply to: 467669272 [](ancestors = 467669272)

eerhardt
eerhardt approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

TomFinley
TomFinley approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ivanidzo4ka

@TomFinley TomFinley merged commit 258a07c into dotnet:master Feb 27, 2019
TomFinley
TomFinley reviewed Feb 27, 2019
View reviewed changes
Microsoft.ML.sln
@@ -260,6 +260,12 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.Data.DataView", "
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RemoteExecutorConsoleApp", "test\RemoteExecutorConsoleApp\RemoteExecutorConsoleApp.csproj", "{5E920CAC-5A28-42FB-936E-49C472130953}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.ML.Ensemble", "Microsoft.ML.Ensemble", "{AD7058C9-5608-49A8-BE23-58C33A74EE91}"
ProjectSection(SolutionItems) = preProject
pkg\Microsoft.ML.Ensemble\Microsoft.ML.Ensemble.nupkgproj = pkg\Microsoft.ML.Ensemble\Microsoft.ML.Ensemble.nupkgproj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not aware of us doing this elsewhere, but that's OK I guess.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomFinley TomFinley TomFinley approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees

@eerhardt eerhardt

@TomFinley TomFinley

@yaeldekel yaeldekel

@sfilipi sfilipi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensemble project shouldn't be part of Microsoft.ML
5 participants
@Ivanidzo4ka @eerhardt @TomFinley @yaeldekel @sfilipi