Skip to content

Preparation for syncing sources with internal repo #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2018
Merged

Preparation for syncing sources with internal repo #275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f94f99
make class partial so I can add constuctor in separate file. add cons…
May 31, 2018
8e1f121
formatting
May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Microsoft.ML.Sweeper/AsyncSweeper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public interface IAsyncSweeper
/// Expose existing <see cref="ISweeper"/>s as <see cref="IAsyncSweeper"/> with no synchronization over the past runs.
/// Nelder-Mead requires synchronization so is not compatible with SimpleAsyncSweeperBase.
/// </summary>
public class SimpleAsyncSweeper : IAsyncSweeper, IDisposable
public partial class SimpleAsyncSweeper : IAsyncSweeper, IDisposable
{
private readonly List<IRunResult> _results;
private readonly object _lock;
Expand All @@ -85,6 +85,16 @@ private SimpleAsyncSweeper(ISweeper baseSweeper)
_results = new List<IRunResult>();
}

public SimpleAsyncSweeper(IHostEnvironment env, UniformRandomSweeper.ArgumentsBase args)
: this(new UniformRandomSweeper(env, args))
{
}

public SimpleAsyncSweeper(IHostEnvironment env, RandomGridSweeper.Arguments args)
: this(new UniformRandomSweeper(env, args))
{
}

public void Update(int id, IRunResult result)
{
Contracts.CheckParam(0 <= id && id < _numGenerated, nameof(id), "Invalid run id");
Expand Down