Update to coverlet 2.6.0 #2843
Merged
Update to coverlet 2.6.0 #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
update-coverlet
branch
from
30dc9de to
59eac50
Compare
Codecov Report
@@ Coverage Diff @@
## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35%
==========================================
Files 812 796 -16
Lines 142659 141949 -710
Branches 16090 16042 -48
==========================================
Hits 102450 102450
+ Misses 35826 35117 -709
+ Partials 4383 4382 -1
|
sharwell
force-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39
Compare
TomFinley
reviewed
Mar 5, 2019
|
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference! |
|
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating. |
zsd4yr
added a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
sharwell
force-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2
Compare
sharwell
commented
Mar 10, 2019
build/Codecoverage.proj
Outdated
| <Message Importance="high" Text=""$(_ReportGeneratorPath)" -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" /> | ||
| <Exec Command=""$(_ReportGeneratorPath)" -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" /> | ||
| <Message Importance="high" Text=""$(_ReportGeneratorPath)" -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" /> | ||
| <Exec Command=""$(_ReportGeneratorPath)" -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" /> |
There was a problem hiding this comment.
📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<class name="Microsoft.ML.StaticPipe.LdaFitResult" filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs" line-rate="0" branch-rate="1" complexity="NaN">
<methods>
<method name=".ctor" signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)" line-rate="0" branch-rate="1">
<line number="24" hits="0" branch="false" />
<line number="25" hits="0" branch="false" />
<line number="26" hits="0" branch="false" />
<line number="27" hits="0" branch="false" />
</method>
</methods>
<lines>
<line number="24" hits="0" branch="false" />
<line number="25" hits="0" branch="false" />
<line number="26" hits="0" branch="false" />
<line number="27" hits="0" branch="false" />
</lines>
</class>
<class name="Microsoft.ML.StaticPipe.LdaFitResult" filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs" line-rate="1" branch-rate="1" complexity="NaN">
<methods>
<method name=".ctor" signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)" line-rate="1" branch-rate="1">
<line number="24" hits="1" branch="false" />
<line number="25" hits="1" branch="false" />
<line number="26" hits="1" branch="false" />
<line number="27" hits="1" branch="false" />
</method>
</methods>
<lines>
<line number="24" hits="1" branch="false" />
<line number="25" hits="1" branch="false" />
<line number="26" hits="1" branch="false" />
<line number="27" hits="1" branch="false" />
</lines>
</class>
|
This should be ready for review. The changes to coverage were primarily the following:
The other coverage changes appear to be normal non-determinism in the coverage runs. |
sharwell
force-pushed
the
update-coverlet
branch
from
dcea8df to
8cc7490
Compare
|
For some reason the button to move this from a draft pull request to a normal pull request is missing here... |
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button... |
sharwell
commented
Mar 11, 2019
sharwell
force-pushed
the
update-coverlet
branch
from
b72d225 to
7f88d7a
Compare
sharwell
force-pushed
the
update-coverlet
branch
from
7f88d7a to
67524ea
Compare
|
Thanks, @sharwell ! |
zsd4yr
added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
* include coverlet.msbuild 2.5.1 * add targets and coverage group * mock dotnet/machinelearning#2843 * Hook coverlet up to the 'RunTests' target * Upload data to codecov.io * Add code coverage badge to the README * Add clarifying comments for code coverage configuration * Move coverage upload after pick/sign/publish
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.