-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrubbing online learners #2892
Merged
Ivanidzo4ka
merged 5 commits into
dotnet:master
from
Ivanidzo4ka:Ivanidze/ScrubbingOnlineLearners
Mar 12, 2019
Merged
Changes from 4 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -95,23 +95,23 @@ public override LinearRegressionModelParameters CreatePredictor() | |||||
/// <param name="featureColumn">Name of the feature column.</param> | ||||||
/// <param name="learningRate">The learning Rate.</param> | ||||||
/// <param name="decreaseLearningRate">Decrease learning rate as iterations progress.</param> | ||||||
/// <param name="l2RegularizerWeight">L2 Regularization Weight.</param> | ||||||
/// <param name="numIterations">Number of training iterations through the data.</param> | ||||||
/// <param name="l2Regularization">Weight of L2 regularization term.</param> | ||||||
/// <param name="numberOfIterations">Number of training iterations through the data.</param> | ||||||
/// <param name="lossFunction">The custom loss functions. Defaults to <see cref="SquaredLoss"/> if not provided.</param> | ||||||
internal OnlineGradientDescentTrainer(IHostEnvironment env, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
A descent algorithm ensures the decrease of function value per iteration. However, this is not true for most stochastic gradient learners. #Pending There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
string labelColumn = DefaultColumnNames.Label, | ||||||
string featureColumn = DefaultColumnNames.Features, | ||||||
float learningRate = Options.OgdDefaultArgs.LearningRate, | ||||||
bool decreaseLearningRate = Options.OgdDefaultArgs.DecreaseLearningRate, | ||||||
float l2RegularizerWeight = Options.OgdDefaultArgs.L2RegularizerWeight, | ||||||
int numIterations = Options.OgdDefaultArgs.NumIterations, | ||||||
float l2Regularization = Options.OgdDefaultArgs.L2Regularization, | ||||||
int numberOfIterations = Options.OgdDefaultArgs.NumberOfIterations, | ||||||
IRegressionLoss lossFunction = null) | ||||||
: this(env, new Options | ||||||
{ | ||||||
LearningRate = learningRate, | ||||||
DecreaseLearningRate = decreaseLearningRate, | ||||||
L2RegularizerWeight = l2RegularizerWeight, | ||||||
NumberOfIterations = numIterations, | ||||||
L2Regularization= l2Regularization, | ||||||
NumberOfIterations = numberOfIterations, | ||||||
LabelColumnName = labelColumn, | ||||||
FeatureColumnName = featureColumn, | ||||||
LossFunction = new TrivialFactory(lossFunction ?? new SquaredLoss()) | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, It's number of iterations.
In reply to: 263972500 [](ancestors = 263972500)