TF package size fix #3983
Merged
TF package size fix #3983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging to personal fork
Syncing upstream fork
Checked in a better fix based on code review (#3896)
Syncing upstream fork
Syncing upstream fork
eerhardt
approved these changes
Jul 10, 2019
artidoro
reviewed
Jul 10, 2019
| <TensorFlowConfig Include="windows" FileExtension=".zip" FilesFromArchive="lib\tensorflow.dll;include\tensorflow\c\LICENSE" Runtime="win-x64"/> | ||
| <TensorFlowConfig Include="linux" FileExtension=".tar.gz" | ||
| FilesFromArchive="lib\libtensorflow.so; | ||
| lib\libtensorflow.so.$(TensorFlowMajorVersion); |
There was a problem hiding this comment.
Are all these dynamic libraries not necessary then?
There was a problem hiding this comment.
The binaries deleted are identical to the ones remaining. They are symlinked in the tar file. But when they get to the nuget package, they become copies.
This change keeps only the ones that are used.
artidoro
reviewed
Jul 10, 2019
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <TensorFlowConfig Include="windows" FileExtension=".zip" FilesFromArchive="lib\tensorflow.dll;include\tensorflow\c\LICENSE" Runtime="win-x64"/> |
There was a problem hiding this comment.
nit: could you format the windows config the same way you did below for linux and mac?
Not important if you are not doing another iteration.
artidoro
approved these changes
Jul 10, 2019
artidoro
approved these changes
Jul 10, 2019
Dmitry-A
pushed a commit
to Dmitry-A/machinelearning
that referenced
this pull request
Jul 24, 2019
* Reduced list of TF binaries to only the essential ones * Fixed formatting
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tensorflow tar files contain libtensorflow.so, libtensorflow.so.$(MajorVersion) and libtensorflow.so.$(Version). Of these, the first two are symlinked to the third. When these files get copied over to the nuget package, they are copied as files and not as symlinks which causes the package size to almost triple.
This fix reduces the copied files to only libtensorflow.so and libtensorflow_framework.so.$(MajorVersion).