-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix FastTree regression samples #4573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4573 +/- ##
==========================================
- Coverage 75.13% 75.1% -0.04%
==========================================
Files 909 909
Lines 160262 160262
Branches 17257 17257
==========================================
- Hits 120409 120357 -52
- Misses 35041 35087 +46
- Partials 4812 4818 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Nevermind, I misread the issue here. 😄 |
Expected output needs no change. These samples used to have the correct trainers and the correct expected output. PR #3948 added the wrong trainers but did not change the expected output. So this is actually the correct expected output (verified). In reply to: 565545246 [](ancestors = 565545246) Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Regression/FastTree.cs:59 in ce78d6e. [](commit_id = ce78d6e, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix #4572
Incorrect trainers added to
FastTreeRegression
andFastTreeTweedieRegression
in PR #3948