Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test can_reload_model #5287

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

frank-dong-ms-zz
Copy link
Contributor

Fix below test failure by increase wait time:

https://dev.azure.com/dnceng/public/_build/results?buildId=716174&view=logs&j=41509eb4-74ce-5e57-61b4-bdf74b39e7c1&t=522d178a-829f-5bff-ccb9-04bea054b64d

error message is like:

X Microsoft.Extensions.ML.FileLoaderTests.can_reload_model [2s 11ms]
Error Message:
FileLoader ChangeToken didn't fire before the allotted time.

this failure is tracked at #5266

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner July 6, 2020 17:35
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #5287 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5287   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files        1022     1022           
  Lines      190320   190320           
  Branches    20470    20470           
=======================================
+ Hits       140232   140237    +5     
+ Misses      44557    44555    -2     
+ Partials     5531     5528    -3     
Flag Coverage Δ
#Debug 73.68% <ø> (+<0.01%) ⬆️
#production 69.42% <ø> (+<0.01%) ⬆️
#test 87.62% <ø> (ø)
Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 66.58% <0.00%> (+0.25%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.45% <0.00%> (+0.47%) ⬆️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 65.56% <0.00%> (+5.96%) ⬆️

@frank-dong-ms-zz frank-dong-ms-zz merged commit 63a1714 into dotnet:master Jul 6, 2020
@frank-dong-ms-zz frank-dong-ms-zz deleted the test-fix branch July 8, 2020 02:50
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants